mirror of
https://github.com/google/cdc-file-transfer.git
synced 2026-09-13 01:10:44 +03:00
[cdc_rsync] Improve throughput for local copies (#74)
On Windows, fclose() seems to be very expensive for large files, where closing a 1 GB file takes up to 5 seconds. This CL calls fclose() in background threads. This tremendously improves local syncs, e.g. copying a 4.5 GB, 300 files data set takes only 7 seconds instead of 30 seconds. Also increases the buffer size for copying from 16K to 128K (better throughput for local copies), and adds a timestamp to debug and verbose console logs (useful when comparing client and server logs).
This commit is contained in:
+20
-2
@@ -18,7 +18,6 @@
|
||||
#define COMMON_THREADPOOL_H_
|
||||
|
||||
#include <atomic>
|
||||
#include <condition_variable>
|
||||
#include <functional>
|
||||
#include <memory>
|
||||
#include <queue>
|
||||
@@ -57,7 +56,8 @@ class Threadpool {
|
||||
void QueueTask(std::unique_ptr<Task> task)
|
||||
ABSL_LOCKS_EXCLUDED(task_queue_mutex_);
|
||||
|
||||
// If available, returns the next completed task.
|
||||
// Returns the next completed task if available or nullptr all are either
|
||||
// queued or in progress.
|
||||
// For a single worker thread (|num_threads| == 1), tasks are completed in
|
||||
// FIFO order. This is no longer the case for multiple threads
|
||||
// (|num_threads| > 1). Tasks that got queued later might complete first.
|
||||
@@ -71,6 +71,14 @@ class Threadpool {
|
||||
std::unique_ptr<Task> GetCompletedTask()
|
||||
ABSL_LOCKS_EXCLUDED(completed_tasks_mutex_);
|
||||
|
||||
using TaskCompletedCallback = std::function<void(std::unique_ptr<Task>)>;
|
||||
|
||||
// Set a callback that is called immediately in a background thread when a
|
||||
// task is completed. The task will not be put onto the completed queue, so
|
||||
// if this callback is set, do not call (Try)GetCompletedTask.
|
||||
void SetTaskCompletedCallback(TaskCompletedCallback cb)
|
||||
ABSL_LOCKS_EXCLUDED(completed_tasks_mutex_);
|
||||
|
||||
// Returns the total number of worker threads in the pool.
|
||||
size_t NumThreads() const { return workers_.size(); }
|
||||
|
||||
@@ -80,6 +88,14 @@ class Threadpool {
|
||||
return outstanding_task_count_;
|
||||
}
|
||||
|
||||
// Block until the number of queued tasks drops below or equal to |count|, or
|
||||
// until the timeout is exceeded, or until Shutdown() is called, whatever
|
||||
// comes sooner. Returns true if less than or equal to |count| tasks are
|
||||
// queued.
|
||||
bool WaitForQueuedTasksAtMost(
|
||||
size_t count, absl::Duration timeout = absl::InfiniteDuration()) const
|
||||
ABSL_LOCKS_EXCLUDED(mutex_);
|
||||
|
||||
private:
|
||||
// Background thread worker method. Picks tasks and runs them.
|
||||
void ThreadWorkerMain()
|
||||
@@ -94,6 +110,8 @@ class Threadpool {
|
||||
absl::Mutex completed_tasks_mutex_;
|
||||
std::queue<std::unique_ptr<Task>> completed_tasks_
|
||||
ABSL_GUARDED_BY(completed_tasks_mutex_);
|
||||
TaskCompletedCallback on_task_completed_
|
||||
ABSL_GUARDED_BY(completed_tasks_mutex_);
|
||||
|
||||
std::vector<std::thread> workers_;
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user