From 8019326cfb6fdecb2273f2e1b90f1e7190dd0763 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=90=D0=BD=D1=82=D0=BE=D0=BD=20=D0=A2=D1=80=D0=BE=D1=88?=
 =?UTF-8?q?=D0=B8=D0=BD?= <i@atroshin.ru>
Date: Thu, 20 Aug 2026 21:39:59 +0300
Subject: [PATCH] Error Action: render builder directly, remove redundant
 subtype select

Error Action (tag 82) now renders buildErrorActionRow() directly in
onBerTypeChange, bypassing the shared ber-subtype select which had
confusing 'Action indicator' option and dead 'Proactive command'/'Custom
hex' choices. Removed the now-unreachable type === 'error' branch from
onBerSubTypeChange.
---
 frontend/index.html | 21 +++++++--------------
 1 file changed, 7 insertions(+), 14 deletions(-)

diff --git a/frontend/index.html b/frontend/index.html
index 61a935d..d0a62a1 100644
--- a/frontend/index.html
+++ b/frontend/index.html
@@ -2066,6 +2066,11 @@ function onBerTypeChange(sel) {
 		body.innerHTML = `<input class="ber-hex w-full font-mono text-xs border border-gray-300 dark:border-slate-600 rounded px-1 py-1 dark:bg-slate-700 dark:text-slate-300" placeholder="hex" oninput="updateBerRow(this)">`;
 	} else if (type === 'chaining') {
 		body.innerHTML = buildScriptChainingRow(row.dataset.berIdx);
+	} else if (type === 'error') {
+		body.innerHTML = buildErrorActionRow();
+		const actionType = body.querySelector('.error-action-type');
+		onErrorActionTypeChange(actionType);
+		updateBerRow(sel);
 	} else {
 		body.innerHTML = `<div class="flex gap-1 mb-1 flex-wrap">
 			<select class="ber-subtype text-xs border border-gray-300 dark:border-slate-600 rounded px-1 py-1 dark:bg-slate-700 dark:text-slate-300" onchange="onBerSubTypeChange(this)">
@@ -2142,26 +2147,14 @@ function onBerSubTypeChange(sel) {
 	const st = sel.value;
 	
 	if (st === 'action') {
-		const row = sel.closest('.ber-row');
-		const type = row.querySelector('.ber-type').value;
-		
-		if (type === 'error') {
-			body.innerHTML = buildErrorActionRow();
-			const actionType = body.querySelector('.error-action-type');
-			onErrorActionTypeChange(actionType);
-		} else {
-			body.innerHTML = `<select class="ber-action text-xs border border-gray-300 dark:border-slate-600 rounded px-1 py-1 dark:bg-slate-700 dark:text-slate-300 font-mono" onchange="updateBerRow(this)">
+		body.innerHTML = `<select class="ber-action text-xs border border-gray-300 dark:border-slate-600 rounded px-1 py-1 dark:bg-slate-700 dark:text-slate-300 font-mono" onchange="updateBerRow(this)">
 				<option value="81">81 (Session indication)</option>
 				<option value="82">82 (Early response)</option>
 			</select>`;
-		}
 	} else if (st === 'custom') {
 		body.innerHTML = `<input class="ber-hex w-full font-mono text-xs border border-gray-300 dark:border-slate-600 rounded px-1 py-1 dark:bg-slate-700 dark:text-slate-300" placeholder="hex" oninput="updateBerRow(this)">`;
 	} else {
-		const row = sel.closest('.ber-row');
-		const type = row.querySelector('.ber-type').value;
-		const allowed = type === 'error' ? ['display','tone'] : undefined;
-		body.innerHTML = buildBerPcHtml(allowed);
+		body.innerHTML = buildBerPcHtml();
 		const pc = body.querySelector('.ber-pc');
 		berPopulateDevices(pc);
 		onBerPcTypeChange(pc.querySelector('.ber-pc-type'));