From e607637782ce682a90616fbedc90bfc926b17c2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=90=D0=BD=D1=82=D0=BE=D0=BD=20=D0=A2=D1=80=D0=BE=D1=88?= =?UTF-8?q?=D0=B8=D0=BD?= Date: Sun, 23 Aug 2026 10:07:56 +0300 Subject: [PATCH] Code review fixes: CB label, trailing newlines - PARSE_INS CB: rename 'RETRIEVE DATA (GET DATA)' -> 'RETRIEVE DATA' (CA = GET DATA, CB = RETRIEVE DATA are separate commands per TS 102 221) - Add trailing newlines to sim.test.js + response_map.test.js --- frontend/index.html | 2 +- frontend/tests/response_map.test.js | 2 +- frontend/tests/sim.test.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/index.html b/frontend/index.html index 1b194a9..9c9a315 100644 --- a/frontend/index.html +++ b/frontend/index.html @@ -2613,7 +2613,7 @@ const PARSE_INS = { 'F2': {name:'GET STATUS', data:'lc'}, 'CA': {name:'GET DATA', data:'none'}, 'DA': {name:'PUT DATA', data:'lc'}, - 'CB': {name:'RETRIEVE DATA (GET DATA)', data:'le'}, + 'CB': {name:'RETRIEVE DATA', data:'le'}, 'DB': {name:'SET DATA', data:'lc'}, 'A2': {name:'SEARCH RECORD', data:'lc'}, '32': {name:'INCREASE', data:'lc'}, diff --git a/frontend/tests/response_map.test.js b/frontend/tests/response_map.test.js index 6b4665c..cc6f4f5 100644 --- a/frontend/tests/response_map.test.js +++ b/frontend/tests/response_map.test.js @@ -54,4 +54,4 @@ test('PRIVILEGE_NAMES matches GPC v2.3 Tables 11-7/11-8/11-9', () => { assert.strictEqual(PRIVILEGE_NAMES[1][7], 'Global Service'); assert.strictEqual(PRIVILEGE_NAMES[2][0], 'Receipt Generation'); assert.strictEqual(PRIVILEGE_NAMES[2][3], 'Contactless Self-Activation'); -}); \ No newline at end of file +}); diff --git a/frontend/tests/sim.test.js b/frontend/tests/sim.test.js index 8f2ed08..d1e5963 100644 --- a/frontend/tests/sim.test.js +++ b/frontend/tests/sim.test.js @@ -153,4 +153,4 @@ test('SELECT by path USIM: P2=04, Le=00', () => { test('SELECT by FID SIM (CLA A0): no Le anywhere', () => { const apdu = setup('sim', { cmd: 'select', selMethod: 'fid', fid: '6FC5' }); assert.strictEqual(apdu, 'A0A40000026FC5'); -}); \ No newline at end of file +});