From 5ef1650696095b4e87a859b8573d4b2fc3848c11 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Sun, 2 May 2021 01:52:56 +0200 Subject: [PATCH] [pylint] Mark abstract CardKeyProvider.get() method as such pySim/card_key_provider.py:67:2: E1111: Assigning result of a function call, where the function has no return (assignment-from-no-return) Change-Id: I43bab69f53300fbe837944735cd999fab5405d7a --- pySim/card_key_provider.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index 05de0be5..67b0b28b 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -30,11 +30,12 @@ operation with pySim-shell. from typing import List, Dict, Optional +import abc import csv card_key_providers = [] # type: List['CardKeyProvider'] -class CardKeyProvider(object): +class CardKeyProvider(abc.ABC): """Base class, not containing any concrete implementation.""" VALID_FIELD_NAMES = ['ICCID', 'ADM1', 'IMSI', 'PIN1', 'PIN2', 'PUK1', 'PUK2'] @@ -67,6 +68,7 @@ class CardKeyProvider(object): result = self.get(fields, key, value) return result.get(field) + @abc.abstractmethod def get(self, fields:List[str], key:str, value:str) -> Dict[str,str]: """Get multiple card-individual fields for identified card. @@ -77,7 +79,6 @@ class CardKeyProvider(object): Returns: dictionary of {field, value} strings for each requested field from 'fields' """ - pass class CardKeyProviderCsv(CardKeyProvider): """Card key provider implementation that allows to query against a specified CSV file"""