catarrh/pysim-local
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unittests/test_files: Pass to-be-encoded length to encoder functions

Browse Source 
Some of the encoders can only generate valid output if they are told
the expected output size.  This is due to variable-length fields that
depend on the size of the total record (or file).  Let's always pass
the expected length to the encoder methods.

Change-Id: I88f957e49b0c88a121a266d3582e79822fa0e214
This commit is contained in:
Harald Welte
2025-12-16 02:55:24 +01:00
parent 82b57403c7
commit 9a23eab163
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/unittests/test_files.py
View File

@@ -96,7 +96,7 @@ class LinFixed_Test(unittest.TestCase):
inst = c() inst = c()
encoded, rec_num, decoded = self._parse_t(t) encoded, rec_num, decoded = self._parse_t(t)
logging.debug("Testing encode of %s", name) logging.debug("Testing encode of %s", name)
re_enc = inst.encode_record_hex(decoded, rec_num) re_enc = inst.encode_record_hex(decoded, rec_num, len(encoded)//2)
self.assertEqual(encoded.upper(), re_enc.upper()) self.assertEqual(encoded.upper(), re_enc.upper())
def test_de_encode_record(self): def test_de_encode_record(self):
@@ -122,7 +122,7 @@ class LinFixed_Test(unittest.TestCase):
self.assertEqual(decoded, re_dec) self.assertEqual(decoded, re_dec)
# re-encode the decoded data # re-encode the decoded data
logging.debug("Testing re-encode of %s", name) logging.debug("Testing re-encode of %s", name)
re_enc = inst.encode_record_hex(re_dec, rec_num) re_enc = inst.encode_record_hex(re_dec, rec_num, len(encoded)//2)
self.assertEqual(encoded.upper(), re_enc.upper()) self.assertEqual(encoded.upper(), re_enc.upper())
if hasattr(c, '_test_no_pad') and c._test_no_pad: if hasattr(c, '_test_no_pad') and c._test_no_pad:
continue continue
@@ -196,7 +196,7 @@ class TransRecEF_Test(unittest.TestCase):
self.assertEqual(decoded, re_dec) self.assertEqual(decoded, re_dec)
# re-encode the decoded data # re-encode the decoded data
logging.debug("Testing re-encode of %s", name) logging.debug("Testing re-encode of %s", name)
re_enc = inst.encode_record_hex(re_dec) re_enc = inst.encode_record_hex(re_dec, len(encoded)//2)
self.assertEqual(encoded.upper(), re_enc.upper()) self.assertEqual(encoded.upper(), re_enc.upper())
# there's no point in testing padded input, as TransRecEF have a fixed record # there's no point in testing padded input, as TransRecEF have a fixed record
# size and we cannot ever receive more input data than that size. # size and we cannot ever receive more input data than that size.
@@ -256,7 +256,7 @@ class TransparentEF_Test(unittest.TestCase):
encoded = t[0] encoded = t[0]
decoded = t[1] decoded = t[1]
logging.debug("Testing encode of %s", name) logging.debug("Testing encode of %s", name)
re_enc = inst.encode_hex(decoded) re_enc = inst.encode_hex(decoded, len(encoded)//2)
self.assertEqual(encoded, re_enc) self.assertEqual(encoded, re_enc)
def test_de_encode_file(self): def test_de_encode_file(self):
@@ -280,7 +280,7 @@ class TransparentEF_Test(unittest.TestCase):
self.assertEqual(decoded, re_dec) self.assertEqual(decoded, re_dec)
logging.debug("Testing re-encode of %s", name) logging.debug("Testing re-encode of %s", name)
re_dec = inst.decode_hex(encoded) re_dec = inst.decode_hex(encoded)
re_enc = inst.encode_hex(re_dec) re_enc = inst.encode_hex(re_dec, len(encoded)//2)
self.assertEqual(encoded.upper(), re_enc.upper()) self.assertEqual(encoded.upper(), re_enc.upper())
if hasattr(c, '_test_no_pad') and c._test_no_pad: if hasattr(c, '_test_no_pad') and c._test_no_pad:
continue continue