catarrh/pysim-local
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

osmo-smdpp: Proper error handling in case ctxParams1 is missing member

Browse Source 
************* Module osmo-smdpp
osmo-smdpp.py:373:15: E0601: Using variable 'iccid_str' before assignment (used-before-assignment)

Change-Id: I52bef18cbcc9f5d14519ff1473532c8502d45908
This commit is contained in:
Harald Welte
2024-08-18 10:46:04 +02:00
committed by laforge
parent 6d4c566fd7
commit a86b1abc03
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osmo-smdpp.py
View File

@@ -368,9 +368,9 @@ class SmDppHttpServer:
with open(path, 'rb') as f:
pes = saip.ProfileElementSequence.from_der(f.read())
iccid_str = b2h(pes.get_pe_for_type('header').decoded['iccid'])
# make pylint happy: E0601: Using variable 'iccid_str' before assignment (used-before-assignment)
assert iccid_str
else:
# there's currently no other option in the ctxParams1 choice, so this cannot happen
raise ApiError('1.3.1', '2.2', 'ctxParams1 missing mandatory ctxParamsForCommonAuthentication')
# FIXME: we actually want to perform the profile binding herr, and read the profile metadat from the profile