From 08ec08fe158a4ab420d881304bfd1e8737fda0d7 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326> Date: Sun, 15 Mar 2026 22:44:56 +0000 Subject: [PATCH] Update patch set 9 Patch Set 9: (1 comment) Patch-set: 9 Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"} --- c9c5bd24701b3d880530775ee3a9c6b45ac57a94 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/c9c5bd24701b3d880530775ee3a9c6b45ac57a94 b/c9c5bd24701b3d880530775ee3a9c6b45ac57a94 index 0563dbc5..7b82287d 100644 --- a/c9c5bd24701b3d880530775ee3a9c6b45ac57a94 +++ b/c9c5bd24701b3d880530775ee3a9c6b45ac57a94 @@ -33,6 +33,24 @@ "message": "The ICCID has a luhn checksum at the end. A wrong checksum may cause the eUICC to just refuse the profile installation. As far as I know, the IncDigitSource just increments, it does not add a checksum or anything.\n\nAs far as I can see you are using enc_iccid to encode the value in apply_val. This function only does the nibble swap. sanitize_iccid would calculate the luhn if it is not yet present, but its only called in validate_val...\n\nMaybe you calculate the luhn somewehere and everything is fine. I am just writing this to make sure you are aware of this.", "revId": "c9c5bd24701b3d880530775ee3a9c6b45ac57a94", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": false, + "key": { + "uuid": "5017d927_a08d38f5", + "filename": "pySim/esim/saip/personalization.py", + "patchSetId": 9 + }, + "lineNbr": 362, + "author": { + "id": 1000005 + }, + "writtenOn": "2026-03-15T22:44:56Z", + "side": 1, + "message": "the luhn is added implicitly, the editable part is without the luhn.\nI know this because we\u0027ve already published ICCID on production SM-DP+ with this code.", + "parentUuid": "96a9a801_96a414a3", + "revId": "c9c5bd24701b3d880530775ee3a9c6b45ac57a94", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file