From 1aae4a0b8826b98bbd2a007a5f63c5b2d2af6682 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Thu, 14 Oct 2021 16:12:42 +0200 Subject: [PATCH] filsystem: Make NotImplementedError more verbose. Before: EXCEPTION of type 'NotImplementedError' occurred with message: '' After: EXCEPTION of type 'NotImplementedError' occurred with message: 'EF(EF.SST) encoder not yet implemented. Patches welcome.' Change-Id: Ie8a10a8847f7c7c6a3332fb9f78de18c9f7f41d0 --- pySim/filesystem.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 5cdac563..8edac411 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -551,7 +551,7 @@ class TransparentEF(CardEF): elif self._tlv: self._tlv.from_dict(abstract_data) return self._tlv.to_tlv() - raise NotImplementedError + raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self) def encode_hex(self, abstract_data:dict) -> str: """Encode abstract representation into raw (hex string) data. @@ -577,7 +577,7 @@ class TransparentEF(CardEF): elif self._tlv: self._tlv.from_dict(abstract_data) return b2h(self._tlv.to_tlv()) - raise NotImplementedError + raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self) class LinFixedEF(CardEF): @@ -787,7 +787,7 @@ class LinFixedEF(CardEF): elif self._tlv: self._tlv.from_dict(abstract_data) return b2h(self._tlv.to_tlv()) - raise NotImplementedError + raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self) def encode_record_bin(self, abstract_data:dict) -> bytearray: """Encode abstract representation into raw (binary) data. @@ -812,7 +812,7 @@ class LinFixedEF(CardEF): elif self._tlv: self._tlv.from_dict(abstract_data) return self._tlv.to_tlv() - raise NotImplementedError + raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self) class CyclicEF(LinFixedEF): """Cyclic EF (Entry File) in the smart card filesystem""" @@ -920,7 +920,7 @@ class TransRecEF(TransparentEF): elif self._tlv: self._tlv.from_dict(abstract_data) return b2h(self._tlv.to_tlv()) - raise NotImplementedError + raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self) def encode_record_bin(self, abstract_data:dict) -> bytearray: """Encode abstract representation into raw (binary) data. @@ -945,7 +945,7 @@ class TransRecEF(TransparentEF): elif self._tlv: self._tlv.from_dict(abstract_data) return self._tlv.to_tlv() - raise NotImplementedError + raise NotImplementedError("%s encoder not yet implemented. Patches welcome." % self) def _decode_bin(self, raw_bin_data:bytearray): chunks = [raw_bin_data[i:i+self.rec_len] for i in range(0, len(raw_bin_data), self.rec_len)]