From 9686b1d96dd3682c0f0bfc804c3c9b35a088337c Mon Sep 17 00:00:00 2001 From: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326> Date: Sat, 7 Mar 2026 14:32:49 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 CC: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326> --- 3b7472f7e13cd7744ffe966e01cf16e1ed65f866 | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/3b7472f7e13cd7744ffe966e01cf16e1ed65f866 b/3b7472f7e13cd7744ffe966e01cf16e1ed65f866 index a578ea8d..57434a4a 100644 --- a/3b7472f7e13cd7744ffe966e01cf16e1ed65f866 +++ b/3b7472f7e13cd7744ffe966e01cf16e1ed65f866 @@ -40,6 +40,29 @@ "revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": true, + "key": { + "uuid": "3509898e_31a05743", + "filename": "pySim/esim/http_json_api.py", + "patchSetId": 1 + }, + "lineNbr": 339, + "author": { + "id": 1000010 + }, + "writtenOn": "2026-03-07T14:32:49Z", + "side": 1, + "message": "This is not a valid type spec. for a tuple. It should be:\n\n```suggestion\n def rewrite_url(self, data: dict, url: str) -\u003e tuple[dict, str]:\n\n```\n\n\nor `Tuple[dict, str]`, in case we care about EOL Python versions \u003c3.9.\n\nIt might be a good idea to do more type checking using pylint (or mypy) during the build verification for Python projects in Jenkins. It could be a separate job just posting comments and printing the resulting code quality score, but not failing the build (V-1).\n\n@osmith@sysmocom.de, @laforge@osmocom.org what do you think?", + "range": { + "startLine": 339, + "startChar": 48, + "endLine": 339, + "endChar": 63 + }, + "revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": {