Update patch set 1

Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000004
2026-03-16 00:25:18 +00:00
committed by Gerrit Code Review
parent 3faf4d42d4
commit bc6e8db4ce

View File

@@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "6004c8f9_8be9b3f4",
"filename": "pySim/global_platform/__init__.py",
"patchSetId": 1
},
"lineNbr": 588,
"author": {
"id": 1000004
},
"writtenOn": "2026-03-16T00:25:18Z",
"side": 1,
"message": "technically correct, but inside pysim we\u0027d usually use our own h2b() function. They date back to python2 where there was no \u0027bytes\u0027 type, and where we had to roll our own. We can clean up the legacy at some point, but until then the code is more readable if it uses our b2h/h2b consistently.",
"range": {
"startLine": 588,
"startChar": 0,
"endLine": 588,
"endChar": 2
},
"revId": "83a7bd6df8d8817aeb6395bf9c0d022d505d3afd",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}