From f104b725550e2b9a708a5b9c8e6ad85df9bb8e7c Mon Sep 17 00:00:00 2001 From: Gerrit Code Review Date: Fri, 3 Nov 2023 07:29:33 +0000 Subject: [PATCH] Update notes for submitted changes * sysmocom_sja2: Add some de/encode test vectors * pySim-shell: Reject any non-decimal PIN values * pySim-shell: permit string with spaces for 'echo' command * pySim-shell: Validate that argument to 'apdu' command is proper hexstr * pySim-shell: Improved argument validation for verify_adm argument --- 1c/849f8bc2aaa9954861703bc6753c8620c2f786 | 8 ++++++++ 4e/59d89a5dec1df4700bf732c1802cf6bfcec38b | 8 ++++++++ 7b/e68b29804dcae6f295a08a117f8d13cb8f5639 | 8 ++++++++ 97/7c5925a174c53568c79ad0084e2afc3da0960b | 8 ++++++++ f9/ea63ea51ef4a7bdf6a7ef531a3da9d2d53468e | 8 ++++++++ 5 files changed, 40 insertions(+) create mode 100644 1c/849f8bc2aaa9954861703bc6753c8620c2f786 create mode 100644 4e/59d89a5dec1df4700bf732c1802cf6bfcec38b create mode 100644 7b/e68b29804dcae6f295a08a117f8d13cb8f5639 create mode 100644 97/7c5925a174c53568c79ad0084e2afc3da0960b create mode 100644 f9/ea63ea51ef4a7bdf6a7ef531a3da9d2d53468e diff --git a/1c/849f8bc2aaa9954861703bc6753c8620c2f786 b/1c/849f8bc2aaa9954861703bc6753c8620c2f786 new file mode 100644 index 00000000..b66b809e --- /dev/null +++ b/1c/849f8bc2aaa9954861703bc6753c8620c2f786 @@ -0,0 +1,8 @@ +Code-Review+1: pespin +Code-Review+2: fixeria +Verified+1: Jenkins Builder +Submitted-by: laforge +Submitted-at: Fri, 03 Nov 2023 07:29:33 +0000 +Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/34948 +Project: pysim +Branch: refs/heads/master diff --git a/4e/59d89a5dec1df4700bf732c1802cf6bfcec38b b/4e/59d89a5dec1df4700bf732c1802cf6bfcec38b new file mode 100644 index 00000000..85addd0e --- /dev/null +++ b/4e/59d89a5dec1df4700bf732c1802cf6bfcec38b @@ -0,0 +1,8 @@ +Verified+1: Jenkins Builder +Code-Review+2: laforge +Code-Review+1: fixeria +Submitted-by: laforge +Submitted-at: Fri, 03 Nov 2023 07:29:33 +0000 +Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/34946 +Project: pysim +Branch: refs/heads/master diff --git a/7b/e68b29804dcae6f295a08a117f8d13cb8f5639 b/7b/e68b29804dcae6f295a08a117f8d13cb8f5639 new file mode 100644 index 00000000..24cd0fa5 --- /dev/null +++ b/7b/e68b29804dcae6f295a08a117f8d13cb8f5639 @@ -0,0 +1,8 @@ +Code-Review+1: pespin +Code-Review+2: fixeria +Verified+1: Jenkins Builder +Submitted-by: laforge +Submitted-at: Fri, 03 Nov 2023 07:29:33 +0000 +Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/34949 +Project: pysim +Branch: refs/heads/master diff --git a/97/7c5925a174c53568c79ad0084e2afc3da0960b b/97/7c5925a174c53568c79ad0084e2afc3da0960b new file mode 100644 index 00000000..3b5fb5a3 --- /dev/null +++ b/97/7c5925a174c53568c79ad0084e2afc3da0960b @@ -0,0 +1,8 @@ +Code-Review+1: pespin +Verified+1: Jenkins Builder +Code-Review+2: fixeria +Submitted-by: laforge +Submitted-at: Fri, 03 Nov 2023 07:29:33 +0000 +Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/34947 +Project: pysim +Branch: refs/heads/master diff --git a/f9/ea63ea51ef4a7bdf6a7ef531a3da9d2d53468e b/f9/ea63ea51ef4a7bdf6a7ef531a3da9d2d53468e new file mode 100644 index 00000000..b4e9f237 --- /dev/null +++ b/f9/ea63ea51ef4a7bdf6a7ef531a3da9d2d53468e @@ -0,0 +1,8 @@ +Code-Review+1: pespin +Code-Review+2: fixeria +Verified+1: Jenkins Builder +Submitted-by: laforge +Submitted-at: Fri, 03 Nov 2023 07:29:33 +0000 +Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/34945 +Project: pysim +Branch: refs/heads/master