Update patch set 11

Patch Set 11: Build Started https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2946/consoleFull Patch-set: 11 Tag: jenkins
Create patch set 11
2026-03-15 22:53:21 +00:00 · 2026-03-15 22:52:52 +00:00 · 2026-03-15 22:46:20 +00:00 · 2026-03-15 22:46:19 +00:00 · 2026-03-15 22:45:57 +00:00 · 2026-03-15 22:44:56 +00:00
2 changed files with 39 additions and 0 deletions
--- a/21
+++ b/21
@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "78f47078_2e2e0c07",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 10
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2026-03-15T22:46:19Z",
+      "side": 1,
+      "message": "(re-add +2 after rebase)",
+      "revId": "4d3d50de6670b02fe416762bceab4964cd741896",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}
--- a/18
+++ b/18
@@ -33,6 +33,24 @@
      "message": "The ICCID has a luhn checksum at the end. A wrong checksum may cause the eUICC to just refuse the profile installation. As far as I know, the IncDigitSource just increments, it does not add a checksum or anything.\n\nAs far as I can see you are using enc_iccid to encode the value in apply_val. This function only does the nibble swap. sanitize_iccid would calculate the luhn if it is not yet present, but its only called in validate_val...\n\nMaybe you calculate the luhn somewehere and everything is fine. I am just writing this to make sure you are aware of this.",
      "revId": "c9c5bd24701b3d880530775ee3a9c6b45ac57a94",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "5017d927_a08d38f5",
+        "filename": "pySim/esim/saip/personalization.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 362,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2026-03-15T22:44:56Z",
+      "side": 1,
+      "message": "the luhn is added implicitly, the editable part is without the luhn.\nI know this because we\u0027ve already published ICCID on production SM-DP+ with this code.",
+      "parentUuid": "96a9a801_96a414a3",
+      "revId": "c9c5bd24701b3d880530775ee3a9c6b45ac57a94",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
 }
Author	SHA1	Message	Date
Gerrit User 1000002	c56e652061	Update patch set 11 Patch Set 11: Build Started https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2946/consoleFull Patch-set: 11 Tag: jenkins	2026-03-15 22:53:21 +00:00
Gerrit User 1000005	15b76b68b6	Create patch set 11 Uploaded patch set 11: Patch Set 10 was rebased. Copied Votes: * Code-Review+2 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN") Patch-set: 11 Subject: personalization: indicate default ParamSource per ConfigurableParameter Commit: `1f50f29546` Tag: autogenerated:gerrit:newPatchSet Groups: `ee0853a149` Copied-Label: Code-Review=+2, 8b4287cacbc131cafa7f6485650ad7e0c520bf4e Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>	2026-03-15 22:52:52 +00:00
Gerrit User 1000002	ca6bcce6ac	Update patch set 10 Patch Set 10: Build Started https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2943/consoleFull Patch-set: 10 Tag: jenkins	2026-03-15 22:46:20 +00:00
Gerrit User 1000005	4f3da69a28	Update patch set 10 Patch Set 10: Code-Review+2 (1 comment) Patch-set: 10 Reviewer: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+2, 8b4287cacbc131cafa7f6485650ad7e0c520bf4e	2026-03-15 22:46:19 +00:00
Gerrit User 1000005	6098fa919e	Create patch set 10 Uploaded patch set 10. Outdated Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN") * Verified+1 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE") Patch-set: 10 Subject: personalization: indicate default ParamSource per ConfigurableParameter Commit: `4d3d50de66` Tag: autogenerated:gerrit:newPatchSet Groups: `3bfa6cc73f` Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"} Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}	2026-03-15 22:45:57 +00:00
Gerrit User 1000005	08ec08fe15	Update patch set 9 Patch Set 9: (1 comment) Patch-set: 9 Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}	2026-03-15 22:44:56 +00:00