{ "comments": [ { "unresolved": true, "key": { "uuid": "c352d841_200e6677", "filename": "pySim/esim/saip/personalization.py", "patchSetId": 6 }, "lineNbr": 56, "author": { "id": 1000004 }, "writtenOn": "2026-01-07T12:49:24Z", "side": 1, "message": "this is somewhat of a copy of pySim.esim.saip.File.file_content_from_tuples, and I think it\u0027s a dangerously incomplete one as it does not understand anything about default file contents \"inherited\" from the specific file template that may be used for a file.\n\n\nIn general I think the proper approach for this is to simply use the existing high-level infrsatructure from the @File()@ instances that are attached to the ProfileElementSeequence, rather than doing a functionally limited re-implementation of it here.\n\nThe added benefit is reduced code duplication, but even more relevant: You get the proper default file contents from the filesystem template, if any was used by the specific input profile.", "range": { "startLine": 56, "startChar": 0, "endLine": 56, "endChar": 2 }, "revId": "e5f0f07835168fb2e8058a35e61417774aaa4eab", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "6748553e_7e8c1591", "filename": "pySim/esim/saip/personalization.py", "patchSetId": 6 }, "lineNbr": 56, "author": { "id": 1000005 }, "writtenOn": "2026-01-15T03:56:18Z", "side": 1, "message": "thanks for helping, because i could not figure this out.\n...actually i still can\u0027t figure out the API.\n\nI tried to find example callers of file_content_from_tuples() but they simply do not exist.\nI\u0027m stuck with from_tuples() which doesn\u0027t do what i want.\n\nEssentially, I need a ProfileElement.get_bytes() function?\nIn detail, how exactly do I improve this caller?\n\n for pe in pes.get_pes_for_type(\u0027usim\u0027):\n imsi_pe \u003d pe.decoded.get(\u0027ef-imsi\u0027, None)\n if imsi_pe:\n yield dec_imsi(b2h(file_tuples_content_as_bytes(imsi_pe)))\n ^^^^^^^^^^^^^^^^^^^\n\nthanks", "parentUuid": "c352d841_200e6677", "range": { "startLine": 56, "startChar": 0, "endLine": 56, "endChar": 2 }, "revId": "e5f0f07835168fb2e8058a35e61417774aaa4eab", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": false, "key": { "uuid": "1fcd61ee_e48dadd4", "filename": "pySim/esim/saip/personalization.py", "patchSetId": 6 }, "lineNbr": 56, "author": { "id": 1000005 }, "writtenOn": "2026-02-15T17:24:00Z", "side": 1, "message": "fixed in subsequent patch .. let me just squash them.", "parentUuid": "6748553e_7e8c1591", "range": { "startLine": 56, "startChar": 0, "endLine": 56, "endChar": 2 }, "revId": "e5f0f07835168fb2e8058a35e61417774aaa4eab", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] }