{ "comments": [ { "unresolved": false, "key": { "uuid": "a594c7a9_a81dc36c", "filename": "/PATCHSET_LEVEL", "patchSetId": 4 }, "lineNbr": 0, "author": { "id": 1000004 }, "writtenOn": "2026-03-10T12:24:05Z", "side": 1, "message": "I would argue actual bugfixes have higher priority and should hence be at the start of a patch series, and not at the end where they\u0027re blocked by more cosmetic changes in front of them", "revId": "b990172d2de51d737d0506c33c392e434040f3e8", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "1c965320_ca854445", "filename": "/PATCHSET_LEVEL", "patchSetId": 4 }, "lineNbr": 0, "author": { "id": 1000004 }, "writtenOn": "2026-03-10T12:26:21Z", "side": 1, "message": "it would be good to introduce some testing of this new fixed handling e.g.by checking the number of remaining PIN attempts which was failing in the OS#6970. Said test could be introduced together with this patch so we can immediately see it now works?", "revId": "b990172d2de51d737d0506c33c392e434040f3e8", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "8f4ae6a0_453a8102", "filename": "/PATCHSET_LEVEL", "patchSetId": 4 }, "lineNbr": 0, "author": { "id": 1000028 }, "writtenOn": "2026-03-10T17:04:22Z", "side": 1, "message": "We could integrate a testcase into the already existing APDU tests by trying if apdu 0020000A00 returns 63c3 properly. That would cover the changes. Without this patch we would get 6f00.", "parentUuid": "1c965320_ca854445", "revId": "b990172d2de51d737d0506c33c392e434040f3e8", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] }