forked from public/pysim
f8ff6bba0d
Patch Set 2:
(3 comments)
Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
126 lines
4.3 KiB
Plaintext
126 lines
4.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8c49721a_3ee61582",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T14:39:24Z",
|
|
"side": 1,
|
|
"message": "I have tested this patch, everything still works fine.",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a5aa9cd0_4710f350",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T15:29:52Z",
|
|
"side": 1,
|
|
"message": "I think claude has chased its own tail here a bit. It first detected that it if the --install-parameters-* are used, all must be used at once, but this was only because the gen_install_parameters had a wrong logical operator (and vs or).",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "65ba7ee0_957615ec",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2026-03-17T15:38:21Z",
|
|
"side": 1,
|
|
"message": "This patch was written before I analyzed pySim with Claude, so if anyone was chasing its own tail here - that was me :) I quickly looked at `gen_install_parameters()` and based on the type hints for arguments (none of them were marked `Optional`) assumed that they\u0027re all mandatory and mutually inclusive. Then I realized that actually they\u0027re all optional.",
|
|
"parentUuid": "a5aa9cd0_4710f350",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "05344e8c_d2a12e07",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 904,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T14:58:31Z",
|
|
"side": 1,
|
|
"message": "When one of the --install-parameters-* is missing we throw an exception. Maybe move this code part to the if branch above and compare with \"not None\"?",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "894d9651_64ad41ca",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 904,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2026-03-17T15:38:21Z",
|
|
"side": 1,
|
|
"message": "I\u0027ll rework this patch and remove the mutually inclusiveness check completely.",
|
|
"parentUuid": "05344e8c_d2a12e07",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "529fa6d8_68998018",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 905,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T14:39:24Z",
|
|
"side": 1,
|
|
"message": "I would write \"--install-parameters cannot be mixed with --install-parameters-* arguments.\". Actually none of those --install-parameters-* is mandatory, see gen_install_parameters in install_param.py",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d557a3f9_b5acaff0",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 905,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2026-03-17T15:38:21Z",
|
|
"side": 1,
|
|
"message": "Thanks for confirming. I realized this later while working on the second patch.",
|
|
"parentUuid": "529fa6d8_68998018",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |