mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-03-17 02:48:34 +03:00
c2a327f4de
Patch Set 10:
(1 comment)
Patch-set: 10
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
56 lines
1.7 KiB
Plaintext
56 lines
1.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f8a52d97_7aafb27a",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-06T12:07:46Z",
|
|
"side": 1,
|
|
"message": "As far as I understand, this patch only extends the patch from before so that we can read back multiple values. (I also see that this patch fixes some unrelated things from the patch before) Maybe it makes sense to squash both patches into one?",
|
|
"revId": "9bc795e7a1b62d842ae9c4e1844882eb0f4b10d7",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2be3fe1e_9d30e01f",
|
|
"filename": "pySim/esim/saip/personalization.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 209,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-06T12:07:46Z",
|
|
"side": 1,
|
|
"message": "Ah, ok here you fix the comment chars. Should be ok then.",
|
|
"revId": "9bc795e7a1b62d842ae9c4e1844882eb0f4b10d7",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "93fc667c_d8eae896",
|
|
"filename": "pySim/esim/saip/personalization.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 209,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2026-03-15T22:42:09Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "2be3fe1e_9d30e01f",
|
|
"revId": "9bc795e7a1b62d842ae9c4e1844882eb0f4b10d7",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |