pysim/3b7472f7e13cd7744ffe966e01cf16e1ed65f866

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "07c133c0_b73f763b",
        "filename": "/COMMIT_MSG",
        "patchSetId": 1
      },
      "lineNbr": 15,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2026-03-06T20:11:54Z",
      "side": 1,
      "message": "(typo)",
      "range": {
        "startLine": 15,
        "startChar": 32,
        "endLine": 15,
        "endChar": 43
      },
      "revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "cffddd1f_7cf3ed06",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2026-03-06T20:11:54Z",
      "side": 1,
      "message": "nothing blocking here, feel free to merge as you see fit!",
      "revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "3509898e_31a05743",
        "filename": "pySim/esim/http_json_api.py",
        "patchSetId": 1
      },
      "lineNbr": 339,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2026-03-07T14:32:49Z",
      "side": 1,
      "message": "This is not a valid type spec. for a tuple. It should be:\n\n```suggestion\n    def rewrite_url(self, data: dict, url: str) -\u003e tuple[dict, str]:\n\n```\n\n\nor `Tuple[dict, str]`, in case we care about EOL Python versions \u003c3.9.\n\nIt might be a good idea to do more type checking using pylint (or mypy) during the build verification for Python projects in Jenkins. It could be a separate job just posting comments and printing the resulting code quality score, but not failing the build (V-1).\n\n@osmith@sysmocom.de, @laforge@osmocom.org what do you think?",
      "range": {
        "startLine": 339,
        "startChar": 48,
        "endLine": 339,
        "endChar": 63
      },
      "revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "73a6a630_6f0289a2",
        "filename": "pySim/esim/http_json_api.py",
        "patchSetId": 1
      },
      "lineNbr": 339,
      "author": {
        "id": 1000028
      },
      "writtenOn": "2026-03-16T14:05:19Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "3509898e_31a05743",
      "range": {
        "startLine": 339,
        "startChar": 48,
        "endLine": 339,
        "endChar": 63
      },
      "revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f26df76c_487ad55d",
        "filename": "pySim/esim/http_json_api.py",
        "patchSetId": 1
      },
      "lineNbr": 373,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2026-03-06T20:11:54Z",
      "side": 1,
      "message": "(typo)",
      "range": {
        "startLine": 373,
        "startChar": 97,
        "endLine": 373,
        "endChar": 106
      },
      "revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d46ac3f2_5f524633",
        "filename": "pySim/esim/http_json_api.py",
        "patchSetId": 1
      },
      "lineNbr": 391,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2026-03-06T20:11:54Z",
      "side": 1,
      "message": "maybe it would be good to complete composition of data before calling rewrite_url()? i mean, maybe rather call rewrite_url() below this line, not above?\n\nthe header shouldn\u0027t ever be relevant for rewrite_url, i\u0027m just thinking it would be logically simpler when there is only one relevant state for data...\n\n(unless you chose this order on purpose)",
      "range": {
        "startLine": 391,
        "startChar": 12,
        "endLine": 391,
        "endChar": 16
      },
      "revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}