mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-03-16 18:38:32 +03:00
d121c5b4df
Patch Set 2:
(1 comment)
Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
51 lines
1.5 KiB
Plaintext
51 lines
1.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6004c8f9_8be9b3f4",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 588,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2026-03-16T00:25:18Z",
|
|
"side": 1,
|
|
"message": "technically correct, but inside pysim we\u0027d usually use our own h2b() function. They date back to python2 where there was no \u0027bytes\u0027 type, and where we had to roll our own. We can clean up the legacy at some point, but until then the code is more readable if it uses our b2h/h2b consistently.",
|
|
"range": {
|
|
"startLine": 588,
|
|
"startChar": 0,
|
|
"endLine": 588,
|
|
"endChar": 2
|
|
},
|
|
"revId": "83a7bd6df8d8817aeb6395bf9c0d022d505d3afd",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "68a28803_dbb1c4e9",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 588,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2026-03-16T09:56:37Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "6004c8f9_8be9b3f4",
|
|
"range": {
|
|
"startLine": 588,
|
|
"startChar": 0,
|
|
"endLine": 588,
|
|
"endChar": 2
|
|
},
|
|
"revId": "83a7bd6df8d8817aeb6395bf9c0d022d505d3afd",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |