catarrh/simple
1
0
Fork 0
Code Issues Pull Requests Actions 8 Packages Projects Releases Wiki Activity

v3.30.4 follow-up: the suite delete re-resolves the selection by id

Browse Source 
The independent re-check of the v3.30.4 identity fixes found a
pre-existing gap in testSuiteDelete: it cleared the selection only when
the deleted suite WAS the selected one, so deleting a suite BEFORE the
selection left _testSuiteIdx pointing at whatever moved into that slot
(or out of range when the list shrank).

The delete now captures the selected suite's id just before the store
refresh and re-resolves the index after it, which also keeps a selection
the user made while the dialog was open (the modal no longer freezes the
page).

Test: a behavioural test drives the real function through the four cases
(the selected suite deleted; a suite before it deleted; the selection
moved during the dialog; nothing selected) - mutation-checked to fail
without the re-resolution.  946 frontend + 952 Python.
This commit is contained in:
Антон Трошин
2026-10-18 00:35:45 +03:00
parent 9a688207ba
commit 30a742618e
2 changed files with 47 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/index.html
+6 -7
View File
@@ -7598,20 +7598,19 @@ function testSuiteOpen(i) {
async function testSuiteDelete(i) {
const s = testSuites()[i];
if (!s) return;
// resolve the selection before the await: the list may be reordered while
// the confirmation is open (the modal does not block the page), so the
// reset below re-checks by id that the selection still points here
const wasSelected = _testSuiteIdx === i;
const suiteId = s.id;
if (!(await pysimConfirm(t('Delete this test suite?')))) return;
// a pending debounced name write must not 404 after the delete
if (_testSuiteSaveTimer) { clearTimeout(_testSuiteSaveTimer); _testSuiteSaveTimer = null; }
try {
const resp = await pysimFetch('/api/test/suites/delete', {id: s.id});
if (resp.error) throw new Error(resp.error);
// The list may have been reordered while the confirmation was open (the
// modal does not block the page) and the delete itself shifts every
// index after it: re-resolve the selection by id, not by position.
const selId = (testCurrentSuite() || {}).id;
await testStoresFetch();
const cur = testCurrentSuite();
if (wasSelected && (!cur || cur.id === suiteId)) _testSuiteIdx = -1;
const at = testSuites().findIndex(x => x.id === selId);
_testSuiteIdx = at >= 0 ? at : -1;
testViewShow('suites');
} catch (e) {
ioStatus('test-io-status', t('Could not delete the test suite') + ': ' + e.message);