v3.22.0 (review fixes): the quota zero, the suite repair paths, the docs

Second review round on the unpushed v3.20.0-v3.22.0 batch:

- install parameters: a zero memory quota (nv_quota: 0 - the vendor
  reference form's C7 02 0000 C8 02 0000) is composed instead of being
  dropped as "unset" (only None/blank leaves the TLV out); a truncated EF
  length in stk_params is refused instead of read as an empty EF.
- test suites: a suite whose member script is gone is repairable - the
  update endpoint accepts pruning a dangling reference (a removal of a
  live script stays refused; the PWA's row Delete prunes it), and
  reconcile_scripts_to_suites() lists an orphan even when its suite_id
  write is refused by the validator, so a stored script that no longer
  validates stays visible in the editor and fails at run start with the
  message instead of disappearing.
- engine/PWA: the proactive action refuses a check.data (its result data
  is the drained-command list - the check was silently ignored); the
  vestigial _testScriptDraft is gone; berLenStr emits the 2/3-byte BER
  long form (a >255-byte C9 composes correctly).
- docs: api.md (the stop cleanup answers ok, never an automatic cancel;
  the server persists the counters - the PWA does not write them back; the
  suite bundle import always merges the scripts; the quota-0 note) and
  test-scripts.md (the event action covers all modelled events; the
  direct-create path needs a suite_id; the format history); help EN/RU
  counter wording.
- tests: the zero quota / truncated EF, the prune path, the invalid-script
  listing, the proactive data-check refusal, berLenStr and the >255-byte
  C9.  Tests: 839 frontend + 804 Python; sw cache simple-v403.
This commit is contained in:
2026-10-06 01:37:49 +03:00
parent b2cb42caf5
commit e12dfc7871
14 changed files with 196 additions and 36 deletions
+30
View File
@@ -1330,6 +1330,36 @@ class TestScriptStoreHttpTests(unittest.TestCase):
self.assertEqual(status, 400, resp)
self.assertIn('member set changes through the script endpoints', resp['error'])
def test_suite_update_prunes_a_dangling_reference(self):
# The store keeps a suite whose script is gone (servable by design);
# pruning the member entry is the one member-set change the update
# endpoint accepts - no script endpoint can reach it any more.
suite = self._suite(name='stale')
self.suites.update(suite['id'], {'scripts': [
{'script_id': 'f' * 32, 'role': 'member', 'on_fail': 'stop'}]})
# the full list (with the dangling id) is still refused...
status, resp = self._post('/api/test/suites/update', {
'id': suite['id'], 'suite': {'name': 'renamed', 'scripts': [
{'script_id': 'f' * 32, 'role': 'member', 'on_fail': 'stop'}]}})
self.assertEqual(status, 400, resp)
self.assertIn('unknown test script', resp['error'])
# ...but the prune is accepted, and the suite is editable again
status, resp = self._post('/api/test/suites/update', {
'id': suite['id'], 'suite': {'scripts': []}})
self.assertEqual(status, 200, resp)
self.assertEqual(resp['suite']['scripts'], [])
status, resp = self._post('/api/test/suites/update', {
'id': suite['id'], 'suite': {'name': 'renamed'}})
self.assertEqual(status, 200, resp)
self.assertEqual(resp['suite']['name'], 'renamed')
# removing a script that still exists stays the script endpoint's job
status, resp = self._post('/api/test/scripts', self._script(suite_id=suite['id']))
self.assertEqual(status, 200, resp)
status, resp = self._post('/api/test/suites/update', {
'id': suite['id'], 'suite': {'scripts': []}})
self.assertEqual(status, 400, resp)
self.assertIn('member set changes', resp['error'])
def test_move_and_copy_between_suites(self):
a = self._suite(name='a')
b = self._suite(name='b')