v3.22.0 (review fixes): the quota zero, the suite repair paths, the docs
Second review round on the unpushed v3.20.0-v3.22.0 batch: - install parameters: a zero memory quota (nv_quota: 0 - the vendor reference form's C7 02 0000 C8 02 0000) is composed instead of being dropped as "unset" (only None/blank leaves the TLV out); a truncated EF length in stk_params is refused instead of read as an empty EF. - test suites: a suite whose member script is gone is repairable - the update endpoint accepts pruning a dangling reference (a removal of a live script stays refused; the PWA's row Delete prunes it), and reconcile_scripts_to_suites() lists an orphan even when its suite_id write is refused by the validator, so a stored script that no longer validates stays visible in the editor and fails at run start with the message instead of disappearing. - engine/PWA: the proactive action refuses a check.data (its result data is the drained-command list - the check was silently ignored); the vestigial _testScriptDraft is gone; berLenStr emits the 2/3-byte BER long form (a >255-byte C9 composes correctly). - docs: api.md (the stop cleanup answers ok, never an automatic cancel; the server persists the counters - the PWA does not write them back; the suite bundle import always merges the scripts; the quota-0 note) and test-scripts.md (the event action covers all modelled events; the direct-create path needs a suite_id; the format history); help EN/RU counter wording. - tests: the zero quota / truncated EF, the prune path, the invalid-script listing, the proactive data-check refusal, berLenStr and the >255-byte C9. Tests: 839 frontend + 804 Python; sw cache simple-v403.
This commit is contained in:
@@ -222,6 +222,33 @@ class MigrationTests(unittest.TestCase):
|
||||
# idempotent: nothing left to attach
|
||||
self.assertEqual(srv.migrate_scripts_to_suites(scripts, suites), 0)
|
||||
|
||||
def test_an_invalid_script_is_still_listed_by_the_reconciliation(self):
|
||||
# The script store keeps an entry that no longer validates (a
|
||||
# tightened rule must not destroy it). Its suite_id write is refused
|
||||
# by the same validator, but the member list is authoritative: the
|
||||
# script must be listed, or it would be invisible in the PWA and
|
||||
# could never be fixed in the editor.
|
||||
from pysim_simple_server import server as srv
|
||||
from pysim_simple_server import test_scripts
|
||||
with tempfile.TemporaryDirectory() as tmp:
|
||||
path = pathlib.Path(tmp) / 's.json'
|
||||
step = {'type': 'action', 'kind': 'status', 'params': {'attempts': 1}}
|
||||
scripts = test_scripts.TestScriptStore(path) # permissive
|
||||
script = scripts.add({'name': 'stale', 'steps': [step]})
|
||||
|
||||
def validator(raw):
|
||||
raise ValueError('the rule tightened')
|
||||
|
||||
strict = test_scripts.TestScriptStore(path, validator=validator)
|
||||
suites = test_suites.TestSuiteStore(pathlib.Path(tmp) / 'u.json')
|
||||
self.assertEqual(srv.reconcile_scripts_to_suites(strict, suites), 1)
|
||||
imported = suites.find_by_name('Imported scripts')
|
||||
self.assertEqual([e['script_id'] for e in imported['scripts']],
|
||||
[script['id']])
|
||||
# the suite_id write could not go through - the listing is what
|
||||
# keeps the script visible and fixable
|
||||
self.assertIsNone(strict.get(script['id'])['suite_id'])
|
||||
|
||||
def test_the_reconciliation_adopts_listed_and_missing_suite_scripts(self):
|
||||
# The general invariant repair: a script whose suite_id points at a
|
||||
# missing suite (a suites import with mode replace) joins "Imported
|
||||
|
||||
Reference in New Issue
Block a user