esim: decode the notification operations from the card's TLV shape

ListNotification showed 'pmo' as the operation for every notification:
pySim's ProfileMgmtOperation is a Struct whose first (ignored) byte is
the padding-bits octet, so a TLV parsed from the card nests the flags
under 'pmo' while an object built from decoded flags (the unit-test path)
does not.  The mapping iterated the outer dict and reported the nested
dict as a truthy key.

- esim._profile_operations() accepts both shapes and returns the set
  flags in spec/bit order (install, enable, disable, delete).
- tests: a notification parsed from the card-shaped raw TLV (padding
  octet included) plus the helper's both-shapes/multi-flag cases.
- docs: /api/esim/notifications and the repo AGENTS note.
This commit is contained in:
2026-09-22 00:30:32 +03:00
parent a7ec67b19c
commit f87f3e9841
3 changed files with 47 additions and 4 deletions
+28
View File
@@ -161,6 +161,34 @@ class EsimTests(unittest.TestCase):
'address': 'smdp.example.org', 'iccid': '8970119000004002667',
}])
def test_notifications_parses_operations_from_the_card_tlv(self):
# The card's ProfileMgmtOperation TLV (padding octet + flags octet,
# SGP.22 5.7.9) nests the flags under 'pmo' when pySim parses it.
app, _ = make_app()
address = '6D6E6F2D30302E6573696D73657276696365732E636F6D' # mno-00.esimservices.com
meta = _tlv(0xBF2F, _tlv(0x80, '00') + _tlv(0x81, '0140')
+ _tlv(0x0C, address) + _tlv(0x5A, '980711090000042066F7'))
resp = ListNotificationResp()
resp.from_tlv(bytes.fromhex(_tlv(0xBF28, _tlv(0xA0, meta))))
self.patch([resp])
out = esim.notifications(app)
self.assertIsNone(out['error'])
self.assertEqual(out['notifications'], [{
'seq_number': 0, 'operations': ['enable'],
'address': 'mno-00.esimservices.com',
'iccid': '8970119000004002667',
}])
def test_profile_operations_handles_both_shapes(self):
self.assertEqual(esim._profile_operations(
{'pmo': {'install': False, 'enable': True, 'disable': False,
'delete': True}}), ['enable', 'delete'])
self.assertEqual(esim._profile_operations(
{'install': True, 'enable': False, 'disable': False, 'delete': False}),
['install'])
self.assertEqual(esim._profile_operations(None), [])
self.assertEqual(esim._profile_operations('pmo'), [])
def test_chip_info_collects_parts_and_errors(self):
app, _ = make_app()
self.patch_eid('89049032000000000000000000000001')