catarrh/simtrace2
1
0
Fork 0
mirror of https://gitea.osmocom.org/sim-card/simtrace2.git synced 2026-03-23 00:38:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

card_emu: Avoid PTS related race-condition

Browse Source 
We should not set the new Fi/Di values before we actually transmitted
the PTSS PCK at the old baud rate first.
This commit is contained in:
Harald Welte
2016-03-20 13:38:05 +01:00
parent ccb8a22037
commit 52d554657c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/src_simtrace/card_emu.c
View File

@@ -440,8 +440,6 @@ static int tx_byte_pts(struct card_handle *ch)
break; break;
case PTS_S_WAIT_RESP_PCK: case PTS_S_WAIT_RESP_PCK:
byte = ch->pts.resp[_PCK]; byte = ch->pts.resp[_PCK];
/* update baud rate generator with Fi/Di */
emu_update_fidi(ch);
break; break;
default: default:
TRACE_ERROR("get_byte_pts() in invalid state %u\r\n", TRACE_ERROR("get_byte_pts() in invalid state %u\r\n",
@@ -456,6 +454,8 @@ static int tx_byte_pts(struct card_handle *ch)
switch (ch->pts.state) { switch (ch->pts.state) {
case PTS_S_WAIT_RESP_PCK: case PTS_S_WAIT_RESP_PCK:
/* update baud rate generator with Fi/Di */
emu_update_fidi(ch);
/* Wait for the next TPDU */ /* Wait for the next TPDU */
card_set_state(ch, ISO_S_WAIT_TPDU); card_set_state(ch, ISO_S_WAIT_TPDU);
set_pts_state(ch, PTS_S_WAIT_REQ_PTSS); set_pts_state(ch, PTS_S_WAIT_REQ_PTSS);