catarrh/simtrace2
1
0
Fork 0
mirror of https://gitea.osmocom.org/sim-card/simtrace2.git synced 2026-03-25 17:58:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

usb_buf: Limit the maximum queue length to 3 elements

Browse Source 
If there are already three elements in the to-be-transmitted queue
for the EP, let's free the first element of the queue.  This is a
clear indication that the USB host is not polling the endpoint
regularly.  Maybe there's no host application running at all?

This should obsolete Change-Id Ie9ebdd2ff966f67c9afd1ed760f106558f0091ad

Change-Id: Ie15183f16b22193ffdaf01845db2eae4c7f43c17
Closes: OS#4251
This commit is contained in:
Harald Welte
2019-12-14 19:13:14 +01:00
parent f4a625be53
commit a14616c096
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
firmware/libcommon/source/usb_buf.c
View File

@@ -24,6 +24,7 @@
#include <errno.h> #include <errno.h>
#define USB_ALLOC_SIZE 280 #define USB_ALLOC_SIZE 280
#define USB_MAX_QLEN 3
static struct usb_buffered_ep usb_buffered_ep[BOARD_USB_NUMENDPOINTS]; static struct usb_buffered_ep usb_buffered_ep[BOARD_USB_NUMENDPOINTS];
@@ -78,6 +79,17 @@ int usb_buf_submit(struct msgb *msg)
/* no need for irqsafe operation, as the usb_tx_queue is /* no need for irqsafe operation, as the usb_tx_queue is
* processed only by the main loop context */ * processed only by the main loop context */
if (ep->queue_len > USB_MAX_QLEN) {
struct msgb *evict;
/* free the first pending buffer in the queue */
TRACE_INFO("EP%02x: dropping first queue element (qlen=%u)\r\n",
ep->ep, ep->queue_len);
evict = msgb_dequeue_count(&ep->queue, &ep->queue_len);
OSMO_ASSERT(evict);
usb_buf_free(evict);
}
msgb_enqueue_count(&ep->queue, msg, &ep->queue_len); msgb_enqueue_count(&ep->queue, msg, &ep->queue_len);
return 0; return 0;
} }