catarrh/simtrace2
1
0
Fork 0
mirror of https://gitea.osmocom.org/sim-card/simtrace2.git synced 2026-03-16 21:28:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

I2C: return error after failed write

Browse Source 
The previous mechanism of retrying a failed write could become a
infinite blocking loop (until watchdog tiemout).

Also the array size is used to know how much data to write and verify
instead of a constant.

Change-Id: I8d2d090c5f4d1195f4c7eb29b3958a7bb05f56ec
This commit is contained in:
Kévin Redon
2018-07-24 09:54:12 +02:00
parent 57b60d23cf
commit a71a6f48cb
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
firmware/libboard/qmod/source/board_qmod.c
View File

@@ -70,8 +70,6 @@ const unsigned char __eeprom_bin[256] = {
#include "i2c.h" #include "i2c.h"
static int write_hub_eeprom(void) static int write_hub_eeprom(void)
{ {
const unsigned int __eeprom_bin_len = 256;
int i; int i;
/* wait */ /* wait */
@@ -79,16 +77,18 @@ static int write_hub_eeprom(void)
TRACE_INFO("Writing EEPROM...\n\r"); TRACE_INFO("Writing EEPROM...\n\r");
/* write the EEPROM once */ /* write the EEPROM once */
for (i = 0; i < 256; i++) { for (i = 0; i < ARRAY_SIZE(__eeprom_bin); i++) {
int rc = eeprom_write_byte(0x50, i, __eeprom_bin[i]); int rc = eeprom_write_byte(0x50, i, __eeprom_bin[i]);
/* if the result was negative, repeat that write */ if (rc < 0) {
if (rc < 0) TRACE_ERROR("Writing EEPROM failed at byte %u: 0x%02x\n\r",
i--; i, __eeprom_bin[i]);
return 1;
}
} }
/* then pursue re-reading it again and again */ /* then pursue re-reading it again and again */
TRACE_INFO("Verifying EEPROM...\n\r"); TRACE_INFO("Verifying EEPROM...\n\r");
for (i = 0; i < 256; i++) { for (i = 0; i < ARRAY_SIZE(__eeprom_bin); i++) {
int byte = eeprom_read_byte(0x50, i); int byte = eeprom_read_byte(0x50, i);
TRACE_INFO("0x%02x: %02x\n\r", i, byte); TRACE_INFO("0x%02x: %02x\n\r", i, byte);
if (byte != __eeprom_bin[i]) if (byte != __eeprom_bin[i])