catarrh/simtrace2
1
0
Fork 0
mirror of https://gitea.osmocom.org/sim-card/simtrace2.git synced 2026-03-16 21:28:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

firmware/sniffer: Fix programming error in PPS

Browse Source 
process_byte_pps() would never enter the error path in which the
first byte would be != 0xff.  However, the caller already verified
this before calling process_byte_pps() so the error path should
never be hit anyway.

Change-Id: Ia74b6338219a6965e6bd35a6efcf369890e02d81
This commit is contained in:
Harald Welte
2022-11-16 11:05:44 +01:00
committed by laforge
parent cc295f6945
commit db1e37b93b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/libcommon/source/sniffer.c
View File

@@ -595,7 +595,7 @@ static void process_byte_pps(uint8_t byte)
switch (pps_state) { /* see ISO/IEC 7816-3:2006 section 9.2 */ switch (pps_state) { /* see ISO/IEC 7816-3:2006 section 9.2 */
case PPS_S_WAIT_PPSS: /*!< initial byte */ case PPS_S_WAIT_PPSS: /*!< initial byte */
flags = 0; flags = 0;
if (0xff) { if (byte == 0xff) {
pps_cur[0] = byte; pps_cur[0] = byte;
pps_state = PPS_S_WAIT_PPS0; /* go to next state */ pps_state = PPS_S_WAIT_PPS0; /* go to next state */
} else { } else {