From fe763b76985f243406db3ac42ece032712c48ae2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Redon?= Date: Tue, 3 Jul 2018 16:17:56 +0200 Subject: [PATCH] sniffing: decrease USB IRQ prioprity to prevent USART overrun Handling the USB message queue is done in an ISR and take quite some time. This can cause a USART/SIM sniffing buffer overrun, resulting in data loss. By setting the USB IRQ lower than the USART IRQ, the USB ISR can be interrupted (for short) and no data gets lost. Change-Id: I870a0aa8e251bbb53249c54bfcaa45de5b5a9486 --- firmware/libcommon/source/sniffer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c index 1b6d5e78..2a7ae5f2 100644 --- a/firmware/libcommon/source/sniffer.c +++ b/firmware/libcommon/source/sniffer.c @@ -829,6 +829,10 @@ void Sniffer_init(void) sniff_usart.base->US_RTOR = 9600-12; /* -12 because the timer starts at the end of the 12 ETU frame */ /* Enable interrupt to indicate when data has been received or timeout occurred */ USART_EnableIt(sniff_usart.base, US_IER_RXRDY | US_IER_TIMEOUT); + /* Set USB priority lower than USART to not miss sniffing data (both at 0 per default) */ + if (NVIC_GetPriority(IRQ_USART_SIM)>=NVIC_GetPriority(UDP_IRQn)) { + NVIC_SetPriority(UDP_IRQn, NVIC_GetPriority(IRQ_USART_SIM)+2); + } /* Enable interrupt requests for the USART peripheral */ NVIC_EnableIRQ(IRQ_USART_SIM);