mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-05-01 16:22:27 +03:00
Update patch set 4
Patch Set 4:
(7 comments)
Patch-set: 4
CC: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010
committed by
Gerrit Code Review
Gerrit Code Review
parent
34e4b0e5cb
commit
1636d21b78
@@ -16,6 +16,167 @@
|
||||
"message": "I managed to find a source for the KVN range used with SCP80. So all open questions have found an answer now.",
|
||||
"revId": "d82f047f91134f5f74d9d38cffc250d25d7bcd7d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9a08cf9e_2c3d4711",
|
||||
"filename": "docs/put_key-tutorial.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 16,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2026-03-19T19:19:44Z",
|
||||
"side": 1,
|
||||
"message": "It\u0027s",
|
||||
"range": {
|
||||
"startLine": 16,
|
||||
"startChar": 6,
|
||||
"endLine": 16,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "d82f047f91134f5f74d9d38cffc250d25d7bcd7d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7ceaf48a_a1171787",
|
||||
"filename": "docs/put_key-tutorial.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 39,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2026-03-19T19:19:44Z",
|
||||
"side": 1,
|
||||
"message": "[two domains] exist",
|
||||
"range": {
|
||||
"startLine": 39,
|
||||
"startChar": 27,
|
||||
"endLine": 39,
|
||||
"endChar": 33
|
||||
},
|
||||
"revId": "d82f047f91134f5f74d9d38cffc250d25d7bcd7d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e1e6bc27_6b31c18e",
|
||||
"filename": "docs/put_key-tutorial.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 46,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2026-03-19T19:19:44Z",
|
||||
"side": 1,
|
||||
"message": "there will be",
|
||||
"range": {
|
||||
"startLine": 46,
|
||||
"startChar": 97,
|
||||
"endLine": 46,
|
||||
"endChar": 107
|
||||
},
|
||||
"revId": "d82f047f91134f5f74d9d38cffc250d25d7bcd7d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f176888e_78814630",
|
||||
"filename": "docs/put_key-tutorial.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 68,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2026-03-19T19:19:44Z",
|
||||
"side": 1,
|
||||
"message": "something is not right here, do you mean \"we simply force pySim-shell\"?",
|
||||
"range": {
|
||||
"startLine": 67,
|
||||
"startChar": 89,
|
||||
"endLine": 68,
|
||||
"endChar": 57
|
||||
},
|
||||
"revId": "d82f047f91134f5f74d9d38cffc250d25d7bcd7d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "580b829a_2579c42a",
|
||||
"filename": "docs/put_key-tutorial.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 91,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2026-03-19T19:19:44Z",
|
||||
"side": 1,
|
||||
"message": "Maybe add an extra warning/clarification here that each card has its own unique keyset, and the given example values are not valid for other cards?",
|
||||
"range": {
|
||||
"startLine": 91,
|
||||
"startChar": 0,
|
||||
"endLine": 91,
|
||||
"endChar": 58
|
||||
},
|
||||
"revId": "d82f047f91134f5f74d9d38cffc250d25d7bcd7d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "3640903d_6550ce3e",
|
||||
"filename": "docs/put_key-tutorial.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 108,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2026-03-19T19:19:44Z",
|
||||
"side": 1,
|
||||
"message": "Don\u0027t we need to specify `--key-ver 122` here?",
|
||||
"range": {
|
||||
"startLine": 108,
|
||||
"startChar": 33,
|
||||
"endLine": 108,
|
||||
"endChar": 48
|
||||
},
|
||||
"revId": "d82f047f91134f5f74d9d38cffc250d25d7bcd7d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "078ef73b_2442bb88",
|
||||
"filename": "docs/put_key-tutorial.rst",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 440,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2026-03-19T19:19:44Z",
|
||||
"side": 1,
|
||||
"message": "Looks like the halves of this sentence are swapped. How about: \"the second example shows that different ]]ъu are possible\"?",
|
||||
"range": {
|
||||
"startLine": 440,
|
||||
"startChar": 0,
|
||||
"endLine": 440,
|
||||
"endChar": 60
|
||||
},
|
||||
"revId": "d82f047f91134f5f74d9d38cffc250d25d7bcd7d",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user