mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-06-19 05:54:22 +03:00
Update patch set 10
Patch Set 10: (2 comments) Patch-set: 10 CC: Gerrit User 1000028 <1000028@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
committed by
Gerrit Code Review
parent
8dac1d0832
commit
2f80b52881
@@ -0,0 +1,38 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f8a52d97_7aafb27a",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000028
|
||||
},
|
||||
"writtenOn": "2026-03-06T12:07:46Z",
|
||||
"side": 1,
|
||||
"message": "As far as I understand, this patch only extends the patch from before so that we can read back multiple values. (I also see that this patch fixes some unrelated things from the patch before) Maybe it makes sense to squash both patches into one?",
|
||||
"revId": "9bc795e7a1b62d842ae9c4e1844882eb0f4b10d7",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "2be3fe1e_9d30e01f",
|
||||
"filename": "pySim/esim/saip/personalization.py",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 209,
|
||||
"author": {
|
||||
"id": 1000028
|
||||
},
|
||||
"writtenOn": "2026-03-06T12:07:46Z",
|
||||
"side": 1,
|
||||
"message": "Ah, ok here you fix the comment chars. Should be ok then.",
|
||||
"revId": "9bc795e7a1b62d842ae9c4e1844882eb0f4b10d7",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user