From 5c514fca2ba932a72e4a883283b19fc59bbf123a Mon Sep 17 00:00:00 2001
From: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Date: Wed, 18 Mar 2026 08:40:39 +0000
Subject: [PATCH] Update patch set 4

Patch Set 4:

(4 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
---
 27031e78d9b3f9c7c5d2c215c275098bf0f34bcb | 18 ++++++++
 9aeac8f5df6b9253f703f76dfb7bdadb7443479b | 54 ++++++++++++++++++++++++
 2 files changed, 72 insertions(+)

diff --git a/27031e78d9b3f9c7c5d2c215c275098bf0f34bcb b/27031e78d9b3f9c7c5d2c215c275098bf0f34bcb
index 23bc5edf..ebc3a8f6 100644
--- a/27031e78d9b3f9c7c5d2c215c275098bf0f34bcb
+++ b/27031e78d9b3f9c7c5d2c215c275098bf0f34bcb
@@ -16,6 +16,24 @@
       "message": "I think the error here is that it should be \u0027or\u0027 instead of \u0027and\u0027. Only then the following code makes sense.",
       "revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "7c197ba7_3a7ad2ba",
+        "filename": "pySim/global_platform/install_param.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 58,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2026-03-18T08:40:39Z",
+      "side": 0,
+      "message": "You\u0027re checking each parameter individually anyway, so this top-level if-statement is not needed. It\u0027s redundant, so I am removing it in this patch.",
+      "parentUuid": "d00b8813_e4d76196",
+      "revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }
\ No newline at end of file
diff --git a/9aeac8f5df6b9253f703f76dfb7bdadb7443479b b/9aeac8f5df6b9253f703f76dfb7bdadb7443479b
index eea562c0..915a0f7f 100644
--- a/9aeac8f5df6b9253f703f76dfb7bdadb7443479b
+++ b/9aeac8f5df6b9253f703f76dfb7bdadb7443479b
@@ -34,6 +34,24 @@
       "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "6a6df36a_1ea13900",
+        "filename": "pySim/global_platform/__init__.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 901,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2026-03-18T08:40:39Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "22e1f0a3_9b8a25df",
+      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
@@ -68,6 +86,24 @@
       "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e1c76a65_c1199d38",
+        "filename": "pySim/global_platform/install_param.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 67,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2026-03-18T08:40:39Z",
+      "side": 1,
+      "message": "Well, this is literally what the code does:\n\n* `if system_specific_params:`\n * If system specific parameters are present,\n* `install_params_dict.append(...)`\n * add them to the install parameters.\n\nDo we really need that level of verbosity in comments?",
+      "parentUuid": "5e06b89d_f4093258",
+      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
@@ -84,6 +120,24 @@
       "message": "interesting that this does not change in behavior.",
       "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1cf491e1_af6f8640",
+        "filename": "tests/unittests/test_globalplatform.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 298,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2026-03-18T08:40:39Z",
+      "side": 1,
+      "message": "Not sure what you mean where, but let me explain why I am changing this line.\n\nAn empty string is not `None`, so `gen_install_parameters()` appends a single empty parameter. This causes the unit test to fail, so this is why I am removing the arguments here (this way they all become `None`).",
+      "parentUuid": "c798f8f3_49d13fda",
+      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }
\ No newline at end of file