diff --git a/27031e78d9b3f9c7c5d2c215c275098bf0f34bcb b/27031e78d9b3f9c7c5d2c215c275098bf0f34bcb new file mode 100644 index 00000000..23bc5edf --- /dev/null +++ b/27031e78d9b3f9c7c5d2c215c275098bf0f34bcb @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "d00b8813_e4d76196", + "filename": "pySim/global_platform/install_param.py", + "patchSetId": 3 + }, + "lineNbr": 58, + "author": { + "id": 1000028 + }, + "writtenOn": "2026-03-17T15:25:07Z", + "side": 0, + "message": "I think the error here is that it should be \u0027or\u0027 instead of \u0027and\u0027. Only then the following code makes sense.", + "revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + } + ] +} \ No newline at end of file diff --git a/9aeac8f5df6b9253f703f76dfb7bdadb7443479b b/9aeac8f5df6b9253f703f76dfb7bdadb7443479b new file mode 100644 index 00000000..eea562c0 --- /dev/null +++ b/9aeac8f5df6b9253f703f76dfb7bdadb7443479b @@ -0,0 +1,89 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "8053374f_2281dce9", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 3 + }, + "lineNbr": 0, + "author": { + "id": 1000028 + }, + "writtenOn": "2026-03-17T15:25:07Z", + "side": 1, + "message": "This patch looks correct to me but it needs polishing.", + "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "22e1f0a3_9b8a25df", + "filename": "pySim/global_platform/__init__.py", + "patchSetId": 3 + }, + "lineNbr": 901, + "author": { + "id": 1000028 + }, + "writtenOn": "2026-03-17T15:25:07Z", + "side": 1, + "message": "Better fix this in the patch before.", + "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "b9231988_b76b76bc", + "filename": "pySim/global_platform/install_param.py", + "patchSetId": 3 + }, + "lineNbr": 60, + "author": { + "id": 1000028 + }, + "writtenOn": "2026-03-17T15:25:07Z", + "side": 1, + "message": "this looks correct, but I would add some comments to make the code easier to understand:\n\n# collect system specific parameters (optional)", + "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "5e06b89d_f4093258", + "filename": "pySim/global_platform/install_param.py", + "patchSetId": 3 + }, + "lineNbr": 67, + "author": { + "id": 1000028 + }, + "writtenOn": "2026-03-17T15:25:07Z", + "side": 1, + "message": "# If system specific parameters are present, add them to the install parameters", + "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "c798f8f3_49d13fda", + "filename": "tests/unittests/test_globalplatform.py", + "patchSetId": 3 + }, + "lineNbr": 298, + "author": { + "id": 1000028 + }, + "writtenOn": "2026-03-17T15:25:07Z", + "side": 1, + "message": "interesting that this does not change in behavior.", + "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + } + ] +} \ No newline at end of file