public/pysim
1
0
Fork 1
mirror of https://gitea.osmocom.org/sim-card/pysim.git synced 2026-05-02 14:42:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 2

Browse Source 
Patch Set 2:

(3 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010
2026-03-17 15:38:21 +00:00
committed by Gerrit Code Review
parent 78ec32c0a8
commit f8ff6bba0d
1 changed files with 54 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
27031e78d9b3f9c7c5d2c215c275098bf0f34bcb
View File

@@ -34,6 +34,24 @@
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "65ba7ee0_957615ec",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000010
},
"writtenOn": "2026-03-17T15:38:21Z",
"side": 1,
"message": "This patch was written before I analyzed pySim with Claude, so if anyone was chasing its own tail here - that was me :) I quickly looked at `gen_install_parameters()` and based on the type hints for arguments (none of them were marked `Optional`) assumed that they\u0027re all mandatory and mutually inclusive. Then I realized that actually they\u0027re all optional.",
"parentUuid": "a5aa9cd0_4710f350",
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -51,6 +69,24 @@
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "894d9651_64ad41ca",
"filename": "pySim/global_platform/__init__.py",
"patchSetId": 2
},
"lineNbr": 904,
"author": {
"id": 1000010
},
"writtenOn": "2026-03-17T15:38:21Z",
"side": 1,
"message": "I\u0027ll rework this patch and remove the mutually inclusiveness check completely.",
"parentUuid": "05344e8c_d2a12e07",
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@@ -67,6 +103,24 @@
"message": "I would write \"--install-parameters cannot be mixed with --install-parameters-* arguments.\". Actually none of those --install-parameters-* is mandatory, see gen_install_parameters in install_param.py",
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "d557a3f9_b5acaff0",
"filename": "pySim/global_platform/__init__.py",
"patchSetId": 2
},
"lineNbr": 905,
"author": {
"id": 1000010
},
"writtenOn": "2026-03-17T15:38:21Z",
"side": 1,
"message": "Thanks for confirming. I realized this later while working on the second patch.",
"parentUuid": "529fa6d8_68998018",
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}