mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-05-02 14:42:49 +03:00
5c514fca2b
Patch Set 4:
(4 comments)
Patch-set: 4
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
39 lines
1.2 KiB
Plaintext
39 lines
1.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d00b8813_e4d76196",
|
|
"filename": "pySim/global_platform/install_param.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 58,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T15:25:07Z",
|
|
"side": 0,
|
|
"message": "I think the error here is that it should be \u0027or\u0027 instead of \u0027and\u0027. Only then the following code makes sense.",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7c197ba7_3a7ad2ba",
|
|
"filename": "pySim/global_platform/install_param.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 58,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2026-03-18T08:40:39Z",
|
|
"side": 0,
|
|
"message": "You\u0027re checking each parameter individually anyway, so this top-level if-statement is not needed. It\u0027s redundant, so I am removing it in this patch.",
|
|
"parentUuid": "d00b8813_e4d76196",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |