pysim/9aeac8f5df6b9253f703f76dfb7bdadb7443479b

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "8053374f_2281dce9",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 3
      },
      "lineNbr": 0,
      "author": {
        "id": 1000028
      },
      "writtenOn": "2026-03-17T15:25:07Z",
      "side": 1,
      "message": "This patch looks correct to me but it needs polishing.",
      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "22e1f0a3_9b8a25df",
        "filename": "pySim/global_platform/__init__.py",
        "patchSetId": 3
      },
      "lineNbr": 901,
      "author": {
        "id": 1000028
      },
      "writtenOn": "2026-03-17T15:25:07Z",
      "side": 1,
      "message": "Better fix this in the patch before.",
      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "6a6df36a_1ea13900",
        "filename": "pySim/global_platform/__init__.py",
        "patchSetId": 3
      },
      "lineNbr": 901,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2026-03-18T08:40:39Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "22e1f0a3_9b8a25df",
      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "b9231988_b76b76bc",
        "filename": "pySim/global_platform/install_param.py",
        "patchSetId": 3
      },
      "lineNbr": 60,
      "author": {
        "id": 1000028
      },
      "writtenOn": "2026-03-17T15:25:07Z",
      "side": 1,
      "message": "this looks correct, but I would add some comments to make the code easier to understand:\n\n# collect system specific parameters (optional)",
      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "5e06b89d_f4093258",
        "filename": "pySim/global_platform/install_param.py",
        "patchSetId": 3
      },
      "lineNbr": 67,
      "author": {
        "id": 1000028
      },
      "writtenOn": "2026-03-17T15:25:07Z",
      "side": 1,
      "message": "# If system specific parameters are present, add them to the install parameters",
      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e1c76a65_c1199d38",
        "filename": "pySim/global_platform/install_param.py",
        "patchSetId": 3
      },
      "lineNbr": 67,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2026-03-18T08:40:39Z",
      "side": 1,
      "message": "Well, this is literally what the code does:\n\n* `if system_specific_params:`\n * If system specific parameters are present,\n* `install_params_dict.append(...)`\n * add them to the install parameters.\n\nDo we really need that level of verbosity in comments?",
      "parentUuid": "5e06b89d_f4093258",
      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c798f8f3_49d13fda",
        "filename": "tests/unittests/test_globalplatform.py",
        "patchSetId": 3
      },
      "lineNbr": 298,
      "author": {
        "id": 1000028
      },
      "writtenOn": "2026-03-17T15:25:07Z",
      "side": 1,
      "message": "interesting that this does not change in behavior.",
      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1cf491e1_af6f8640",
        "filename": "tests/unittests/test_globalplatform.py",
        "patchSetId": 3
      },
      "lineNbr": 298,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2026-03-18T08:40:39Z",
      "side": 1,
      "message": "Not sure what you mean where, but let me explain why I am changing this line.\n\nAn empty string is not `None`, so `gen_install_parameters()` appends a single empty parameter. This causes the unit test to fail, so this is why I am removing the arguments here (this way they all become `None`).",
      "parentUuid": "c798f8f3_49d13fda",
      "revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}