mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-05-02 02:47:09 +03:00
7a9e072ec0
Patch Set 2: Code-Review-1 (1 comment) Patch-set: 2 Reviewer: Gerrit User 1000028 <1000028@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=-1, d88cd7da3017d351789b421c210fb7ae22be9f33
55 lines
1.7 KiB
Plaintext
55 lines
1.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8c49721a_3ee61582",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T14:39:24Z",
|
|
"side": 1,
|
|
"message": "I have tested this patch, everything still works fine.",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "05344e8c_d2a12e07",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 904,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T14:58:31Z",
|
|
"side": 1,
|
|
"message": "When one of the --install-parameters-* is missing we throw an exception. Maybe move this code part to the if branch above and compare with \"not None\"?",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "529fa6d8_68998018",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 905,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T14:39:24Z",
|
|
"side": 1,
|
|
"message": "I would write \"--install-parameters cannot be mixed with --install-parameters-* arguments.\". Actually none of those --install-parameters-* is mandatory, see gen_install_parameters in install_param.py",
|
|
"revId": "27031e78d9b3f9c7c5d2c215c275098bf0f34bcb",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |