mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-05-02 05:30:59 +03:00
8eddaa0253
Patch Set 3: Code-Review-1 (6 comments) Patch-set: 3 Reviewer: Gerrit User 1000028 <1000028@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=-1, a147b8994eec30d80c09c10a26e59f80e530662d
89 lines
2.6 KiB
Plaintext
89 lines
2.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8053374f_2281dce9",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T15:25:07Z",
|
|
"side": 1,
|
|
"message": "This patch looks correct to me but it needs polishing.",
|
|
"revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "22e1f0a3_9b8a25df",
|
|
"filename": "pySim/global_platform/__init__.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 901,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T15:25:07Z",
|
|
"side": 1,
|
|
"message": "Better fix this in the patch before.",
|
|
"revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b9231988_b76b76bc",
|
|
"filename": "pySim/global_platform/install_param.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 60,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T15:25:07Z",
|
|
"side": 1,
|
|
"message": "this looks correct, but I would add some comments to make the code easier to understand:\n\n# collect system specific parameters (optional)",
|
|
"revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5e06b89d_f4093258",
|
|
"filename": "pySim/global_platform/install_param.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 67,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T15:25:07Z",
|
|
"side": 1,
|
|
"message": "# If system specific parameters are present, add them to the install parameters",
|
|
"revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c798f8f3_49d13fda",
|
|
"filename": "tests/unittests/test_globalplatform.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 298,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-17T15:25:07Z",
|
|
"side": 1,
|
|
"message": "interesting that this does not change in behavior.",
|
|
"revId": "9aeac8f5df6b9253f703f76dfb7bdadb7443479b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |