mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-05-01 22:31:05 +03:00
bd4149fef0
Patch Set 1:
(1 comment)
Patch-set: 1
CC: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
38 lines
1.3 KiB
Plaintext
38 lines
1.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "da987f0b_17e8ce70",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2026-03-19T12:39:50Z",
|
|
"side": 1,
|
|
"message": "This patch wouldn\u0027t alter the behavior of existing APDU scripts. As far as I know pySim-shell, pySim-prog and pySim-read are the only programs that make use of the pySim/transport API. In case there are other projects that use this API, those would need fixing if they still use TPDUs instead of APDUs. If this is a concern we should find an alternative.",
|
|
"revId": "35384b1c963b84b752a1bdd48edd2314a8e33e42",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9c6e719a_072c902c",
|
|
"filename": "pySim/commands.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 93,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2026-03-19T19:25:37Z",
|
|
"side": 1,
|
|
"message": "You\u0027re missing to update API docs here and below (new parameter).",
|
|
"revId": "35384b1c963b84b752a1bdd48edd2314a8e33e42",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |