mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-04-01 00:56:39 +03:00
d2e3219e05
Patch Set 4: Code-Review+1 (1 comment) Patch-set: 4 Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1, 51a4410ddedb3224b6442e7027ff49a92fa303b1
38 lines
1.3 KiB
Plaintext
38 lines
1.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a594c7a9_a81dc36c",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2026-03-10T12:24:05Z",
|
|
"side": 1,
|
|
"message": "I would argue actual bugfixes have higher priority and should hence be at the start of a patch series, and not at the end where they\u0027re blocked by more cosmetic changes in front of them",
|
|
"revId": "b990172d2de51d737d0506c33c392e434040f3e8",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1c965320_ca854445",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2026-03-10T12:26:21Z",
|
|
"side": 1,
|
|
"message": "it would be good to introduce some testing of this new fixed handling e.g.by checking the number of remaining PIN attempts which was failing in the OS#6970. Said test could be introduced together with this patch so we can immediately see it now works?",
|
|
"revId": "b990172d2de51d737d0506c33c392e434040f3e8",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |