public/simtrace2
1
0
Fork 0
mirror of https://gitea.osmocom.org/sim-card/simtrace2.git synced 2026-08-16 02:18:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

firmware: protect uart_tx_queue against ISR

Browse Source 
cardem:
- dispatch_usb_command_cardem() appends to uart_tx_queue from the main loop
- tx_byte_tpdu() dequeues from the USART IRQ handler @ NVIC prio 0

card_handle_reset() has the same issue, drains queue and
frees uart_tx_msg from main loop while the ISR may own them.

All of this needs protection against the irq.

Needs a fixed llist_add_tail_irqsafe(), which called __enable_irq() instead of
restoring the saved PRIMASK for some unknown reason?!?!?!?

Change-Id: I7d9cdcc56263b27dfd4649dfb1da1d67761ee923
This commit is contained in:
Eric Wild
2026-07-28 17:42:32 +02:00
committed by lynxis lazus
parent b36adff672
commit f7170aff42
3 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
firmware/libcommon/include/llist_irqsafe.h
+1 -1
View File
@@ -34,7 +34,7 @@ static inline void llist_add_tail_irqsafe(struct llist_head *_new,
local_irq_save(x);
llist_add_tail(_new, head);
__enable_irq();
local_irq_restore(x);
}
static inline struct llist_head *llist_head_dequeue_irqsafe(struct llist_head *head)