Eric Wild 2ade068fb6 firmware: sniffer: fix ~INS procedure byte comparison ...

(~g_tpdu.packet[1]) == byte can never be true.
Unary ~ applies the integer promotions first,
so for tpdu INS = 0xA4 lhs should be 0x5B but as int
it gets zero extended to at least 16 bits and then flipped,
so it is 0xFFFFFF5B = -165, byte promotes to 0..255.

The ack was therefore dead code -> fallthrough to SW1
branch, fails 0x6x/0x9x test, TPDU gets flagged
SNIFF_DATA_FLAG_ERROR_MALFORMED from what I can tell.
But I am losing track of all these arcane issues to be honest.

Narrow the complement back to 8 bits.
Fyi this is unrelated to signedness and not specific to ARM.

Change-Id: I800f50ef35356429d07aa685ea919e70ec34946e

2026-08-10 16:13:59 +00:00

..

card_emu.c

firmware: card_emu: fix 7816-3 10.3.2 0=256 case

2026-08-10 16:13:59 +00:00

cciddriver.c

Cosmetic: fix CI errors

2023-04-25 17:53:11 +02:00

crcstub.c

firmware: add crc stub to all dfu apps to ensure reliable loading

2021-12-15 14:04:20 +00:00

fputs.c

treewide: remove FSF address

2021-12-14 11:47:21 +01:00

host_communication.c

treewide: remove FSF address

2021-12-14 11:47:21 +01:00

iso7816_4.c

firmware: Enable -Wformat and resolve all related compiler warnings

2018-08-26 10:20:05 +02:00

iso7816_fidi.c

firmware: iso7816_3: fix F/D ratio for Di 8 and 9

2026-07-28 18:22:02 +02:00

main_common.c

treewide: remove FSF address

2021-12-14 11:47:21 +01:00

mitm.c

Structure build system to build for multiple boards/apps/environments

2017-02-27 22:18:45 +01:00

mode_cardemu.c

firmware: protect uart_tx_queue against ISR

2026-08-10 16:13:59 +00:00

mode_ccid.c

replace leading spaces with tabs

2018-07-11 22:01:58 +02:00

pseudo_talloc.c

treewide: remove FSF address

2021-12-14 11:47:21 +01:00

ringbuffer.c

firmware/sniffer: Add + use 16bit ringbuffer

2022-11-19 09:02:23 +00:00

simtrace_iso7816.c

firmware: use the full 11 bit US_FIDI.FI_DI_RATIO

2026-08-10 16:13:59 +00:00

sniffer.c

firmware: sniffer: fix ~INS procedure byte comparison

2026-08-10 16:13:59 +00:00

stack_check.c

firmware: fix builds with gcc stack smashing protection enabled

2020-08-05 11:59:26 +02:00

stdio.c

stdio: Add support for %p format string (pointer address)

2019-12-14 11:47:06 +01:00

string.c

replace leading spaces with tabs

2018-07-11 22:01:58 +02:00

tc_etu.c

treewide: remove FSF address

2021-12-14 11:47:21 +01:00

usb_buf.c

treewide: remove FSF address

2021-12-14 11:47:21 +01:00

usb.c

firmware: usb: call USBD_HAL_DISCONNECT while usb init to recover from resets

2022-03-09 07:21:01 +00:00