Update patch set 11

Patch Set 11: Code-Review+1 (5 comments) Patch-set: 11 Reviewer: Gerrit User 1000028 <1000028@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1, 8955d02e1b62637d08e4d23f6fbb617fd84b6391
2026-03-17 02:48:34 +03:00 · 2026-03-06 11:54:31 +00:00
parent b81beb52ed
commit 048f06e2b3
1 changed files with 89 additions and 0 deletions
--- a/89
+++ b/89
@@ -0,0 +1,89 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "c63004b8_891d58fd",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 11
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000028
+      },
+      "writtenOn": "2026-03-06T11:54:31Z",
+      "side": 1,
+      "message": "I think this patch looks ok. I would recommend to look at decimal_hex_to_str() a bit more closely to make sure it actually does the right thing.",
+      "revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "37303680_0841eeb4",
+        "filename": "pySim/esim/saip/personalization.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 209,
+      "author": {
+        "id": 1000028
+      },
+      "writtenOn": "2026-03-06T11:54:31Z",
+      "side": 1,
+      "message": "As far as I understand \u0027\u0027\u0027 just marks a multiline comment, but shouldn\u0027t this be a doctstring?",
+      "revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "df8adf24_6dd87150",
+        "filename": "pySim/esim/saip/personalization.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 290,
+      "author": {
+        "id": 1000028
+      },
+      "writtenOn": "2026-03-06T11:54:31Z",
+      "side": 1,
+      "message": "also have not seen single quotes as comment chars before...",
+      "revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "7ddc4bfe_68a1a8c5",
+        "filename": "pySim/esim/saip/personalization.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 292,
+      "author": {
+        "id": 1000028
+      },
+      "writtenOn": "2026-03-06T11:54:31Z",
+      "side": 1,
+      "message": "Is it always ensured that we won\u0027t get sometimes bytes and sometimes bytearrays?",
+      "revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "501ac867_7f438d57",
+        "filename": "pySim/esim/saip/personalization.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 297,
+      "author": {
+        "id": 1000028
+      },
+      "writtenOn": "2026-03-06T11:54:31Z",
+      "side": 1,
+      "message": "You are sure that you want to turn val to ascii, like \"4141\" \u003d\u003e \"AA\"? (am a bit confused since the method name suggests more that the input should be a hexstring or a bytearray with decimal digits and the output should be a string with the same digits.)",
+      "revId": "7886e59f82c71cc40c1040c6712e60cdf91f4f45",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}