catarrh/pysim
1
0
Fork 0
mirror of https://gitea.osmocom.org/sim-card/pysim.git synced 2026-03-17 10:58:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 1

Browse Source 
Patch Set 1: Code-Review+1

(4 comments)

Patch-set: 1
Reviewer: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, f05331c0568ce774a86b1ce98150c1ead598b33d
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000005
2026-03-06 20:11:54 +00:00
committed by Gerrit Code Review
parent 3fd9cac633
commit 4e61933d10
1 changed files with 90 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
3b7472f7e13cd7744ffe966e01cf16e1ed65f866 Normal file
View File

@@ -0,0 +1,90 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "07c133c0_b73f763b",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 15,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-06T20:11:54Z",
"side": 1,
"message": "(typo)",
"range": {
"startLine": 15,
"startChar": 32,
"endLine": 15,
"endChar": 43
},
"revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "cffddd1f_7cf3ed06",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-06T20:11:54Z",
"side": 1,
"message": "nothing blocking here, feel free to merge as you see fit!",
"revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "f26df76c_487ad55d",
"filename": "pySim/esim/http_json_api.py",
"patchSetId": 1
},
"lineNbr": 373,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-06T20:11:54Z",
"side": 1,
"message": "(typo)",
"range": {
"startLine": 373,
"startChar": 97,
"endLine": 373,
"endChar": 106
},
"revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "d46ac3f2_5f524633",
"filename": "pySim/esim/http_json_api.py",
"patchSetId": 1
},
"lineNbr": 391,
"author": {
"id": 1000005
},
"writtenOn": "2026-03-06T20:11:54Z",
"side": 1,
"message": "maybe it would be good to complete composition of data before calling rewrite_url()? i mean, maybe rather call rewrite_url() below this line, not above?\n\nthe header shouldn\u0027t ever be relevant for rewrite_url, i\u0027m just thinking it would be logically simpler when there is only one relevant state for data...\n\n(unless you chose this order on purpose)",
"range": {
"startLine": 391,
"startChar": 12,
"endLine": 391,
"endChar": 16
},
"revId": "3b7472f7e13cd7744ffe966e01cf16e1ed65f866",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}