Update notes for submitted changes

* [pylint] Fix referencing undefined variable 'shutil'
* [pylint] Declare abstract LinkBase._send_apdu_raw() method as such
* [pylint] Fix float vs integer division in cards.py
* [pylint] Fix reference to undefined variable 'in_hex'
* [pylint] Mark abstract MagicSimBase class as such
* [pylint] Fix calling non-existing iteritems() of dict
* [pylint] Declare some fields in _MagicSimBase class
* [pylint] Mark abstract CardKeyProvider.get() method as such
* [pylint] fix non-existing 'res' in EF_CNL._encode_record_hex()
This commit is contained in:
Gerrit Code Review
2021-05-02 20:22:15 +00:00
parent 61f51bfb1b
commit 64815ae768
9 changed files with 63 additions and 0 deletions

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24026
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24024
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24029
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24025
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24028
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24032
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24027
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24031
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Code-Review+2: laforge <laforge@osmocom.org>
Verified+1: Jenkins Builder
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Sun, 02 May 2021 20:22:15 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/24030
Project: pysim
Branch: refs/heads/master