Update notes for submitted changes

* Use the generic method read_binary of card class to read PLMNsel
* pySim-read.py: Use the method declared in cards.py to read SPN
* Use the generic method read_record of card class to read SMSP
* Use read_binary function of card class to read GID2 and reduce code duplication
* cards.py: Add generic function to read EF record in card class
* cards.py: Add generic function to read EF binary to card class
* Move parsing of GID2 to generic Card class
This commit is contained in:
Gerrit Code Review
2020-04-01 08:54:52 +00:00
parent 263b1f6201
commit 88a941b856
7 changed files with 49 additions and 0 deletions

View File

@@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Wed, 01 Apr 2020 08:54:52 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/17659
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Wed, 01 Apr 2020 08:54:52 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/17660
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Wed, 01 Apr 2020 08:54:52 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/17696
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Wed, 01 Apr 2020 08:54:52 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/17657
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Wed, 01 Apr 2020 08:54:52 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/17695
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Wed, 01 Apr 2020 08:54:52 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/17697
Project: pysim
Branch: refs/heads/master

View File

@@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: laforge <laforge@osmocom.org>
Submitted-at: Wed, 01 Apr 2020 08:54:52 +0000
Reviewed-on: https://gerrit.osmocom.org/c/pysim/+/17658
Project: pysim
Branch: refs/heads/master