mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-03-16 18:38:32 +03:00
Update patch set 6
Patch Set 6:
(11 comments)
Patch-set: 6
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000005
committed by
Gerrit Code Review
Gerrit Code Review
parent
cf906802e1
commit
a07400b3f0
@@ -17,6 +17,23 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "12d15f1c_2a6a4de9",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "there will be a new patch set soon, thanks for the feedback!",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -34,6 +51,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f24a7bae_34d7aa7a",
|
||||
"filename": "pySim/esim/saip/batch.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 65,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "IIRC the linter warns against passing empty lists as default argument, because in python there can arise an evil twin situation that is hard to see: like some functions change the arg in-place or something, i don\u0027t remember in detail.",
|
||||
"parentUuid": "8d49fed9_a5e0cf4d",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -51,6 +86,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "bd98a8ed_3caf0795",
|
||||
"filename": "pySim/esim/saip/batch.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 80,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "(marking done, bc discussion will be above)",
|
||||
"parentUuid": "e943de47_0f674ba4",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -68,6 +121,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "32c6d044_21645ff6",
|
||||
"filename": "pySim/esim/saip/batch.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 92,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "hm that\u0027s right, it has to be an iter(list), thx",
|
||||
"parentUuid": "e4dbb645_ad12fe16",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -85,6 +156,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "a3e376b3_476ec8e8",
|
||||
"filename": "pySim/esim/saip/batch.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 97,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "it is optional, configured by the caller, whether a CSV file is present. If yes, it will pass nonempty csv_rows and use at least one CsvSource. So the csv_rows !\u003d None case definitely has to be supported.",
|
||||
"parentUuid": "56c19288_ec4788f0",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -102,6 +191,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "df80bc66_187a2e6c",
|
||||
"filename": "pySim/esim/saip/param_source.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 31,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "That is right. The ABC discussion is a slightly dangerous one, because I am pretty firm in my opinion against using it, though not everyone seems to agree with it. It would be great if I am allowed to work without ABC, or otherwise let\u0027s schedule a call, or i will hold a talk about ABC -- either way let\u0027s not list points for and against it here but rather talk in person?",
|
||||
"parentUuid": "f724aaf0_158e7a7f",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -119,6 +226,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b655dbde_252b85c9",
|
||||
"filename": "pySim/esim/saip/param_source.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 42,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "Hmm. it\u0027s even worse, most subclasses completely replace this. I will make a better plan, thanks.",
|
||||
"parentUuid": "587dd973_a74cc8f0",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -136,6 +261,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4cd391b0_8a0ba5dd",
|
||||
"filename": "pySim/esim/saip/param_source.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 51,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "yea you\u0027re right, sometimes i do sometimes i don\u0027t, thx.\n\ni think it\u0027s because this separates the base definitions from the actual implementations, but not important",
|
||||
"parentUuid": "4eb02f63_a84a2c51",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -187,6 +330,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "944bfb95_3efd540d",
|
||||
"filename": "pySim/esim/saip/param_source.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 95,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "heh funny code \u003d) you are right",
|
||||
"parentUuid": "67ab85f0_e87a96f7",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -204,6 +365,24 @@
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c8a453fc_9b4a59b5",
|
||||
"filename": "pySim/esim/saip/param_source.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 121,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "This uses the fact that all BinaryParameter can take a bytes as input value.\nWe could convert to hexstring and then the BinaryParameter can convert back to binary, but by passing just the bytes we skip the two conversions.\n\nA thought could be this: most places now use a string value to pass parameter settings around, so if we define that a string is the preferred way, then i would change this; but the idea in ConfigurableParameter that I took over from the code I got when I started is that a bytes and BytesIO and hexstring all work, so i would leave the patch unchanged.. agreed?",
|
||||
"parentUuid": "f9f5cb63_dc1aa1d8",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
@@ -237,6 +416,24 @@
|
||||
"message": "You could just do if csv_row: return csv_row.get(self.csv_column) else: raise ...?",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "3a1f2a8f_e471a54c",
|
||||
"filename": "pySim/esim/saip/param_source.py",
|
||||
"patchSetId": 6
|
||||
},
|
||||
"lineNbr": 174,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2026-03-10T22:20:49Z",
|
||||
"side": 1,
|
||||
"message": "it\u0027s more like\n\n if not csv_row or not csv_row.get(self.csv_column):\n raise...\n return csv_row.get(self.csv_column)\n\nso i\u0027m pretty sure this patch as it is is the most minimalistic way of writing this \u003d)",
|
||||
"parentUuid": "12fdbdf0_b38d9d6d",
|
||||
"revId": "a65886ca3f8d82f6ec2843babd0cdfaa64b5a700",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user