Update patch set 6

Patch Set 6: Code-Review-1

(1 comment)

Patch-set: 6
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1, b942a40da895f5853e016f4b4a9b9eeba03a1d8d
This commit is contained in:
Gerrit User 1000004
2026-01-07 12:49:24 +00:00
committed by Gerrit Code Review
parent 40b464bd3a
commit c2505e7f4b

View File

@@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "c352d841_200e6677",
"filename": "pySim/esim/saip/personalization.py",
"patchSetId": 6
},
"lineNbr": 56,
"author": {
"id": 1000004
},
"writtenOn": "2026-01-07T12:49:24Z",
"side": 1,
"message": "this is somewhat of a copy of pySim.esim.saip.File.file_content_from_tuples, and I think it\u0027s a dangerously incomplete one as it does not understand anything about default file contents \"inherited\" from the specific file template that may be used for a file.\n\n\nIn general I think the proper approach for this is to simply use the existing high-level infrsatructure from the @File()@ instances that are attached to the ProfileElementSeequence, rather than doing a functionally limited re-implementation of it here.\n\nThe added benefit is reduced code duplication, but even more relevant: You get the proper default file contents from the filesystem template, if any was used by the specific input profile.",
"range": {
"startLine": 56,
"startChar": 0,
"endLine": 56,
"endChar": 2
},
"revId": "e5f0f07835168fb2e8058a35e61417774aaa4eab",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}