catarrh/pysim
1
0
Fork 0
mirror of https://gitea.osmocom.org/sim-card/pysim.git synced 2026-03-19 11:58:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 4

Browse Source 
Patch Set 4: Code-Review+1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 51a4410ddedb3224b6442e7027ff49a92fa303b1
This commit is contained in:
Gerrit User 1000004
2026-03-10 12:26:21 +00:00
committed by Gerrit Code Review
parent 1f17ee5d28
commit d2e3219e05
1 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
b990172d2de51d737d0506c33c392e434040f3e8
View File

@@ -16,6 +16,23 @@
"message": "I would argue actual bugfixes have higher priority and should hence be at the start of a patch series, and not at the end where they\u0027re blocked by more cosmetic changes in front of them",
"revId": "b990172d2de51d737d0506c33c392e434040f3e8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1c965320_ca854445",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2026-03-10T12:26:21Z",
"side": 1,
"message": "it would be good to introduce some testing of this new fixed handling e.g.by checking the number of remaining PIN attempts which was failing in the OS#6970. Said test could be introduced together with this patch so we can immediately see it now works?",
"revId": "b990172d2de51d737d0506c33c392e434040f3e8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}