catarrh/pysim
1
0
Fork 0
forked from public/pysim
Code Pull Requests Activity

Update patch set 4

Browse Source 
Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000028\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000028\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000028
2026-03-10 17:04:22 +00:00
committed by Gerrit Code Review
parent d2e3219e05
commit e754a89d89
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
b990172d2de51d737d0506c33c392e434040f3e8
View File

@@ -33,6 +33,24 @@
"message": "it would be good to introduce some testing of this new fixed handling e.g.by checking the number of remaining PIN attempts which was failing in the OS#6970. Said test could be introduced together with this patch so we can immediately see it now works?", "message": "it would be good to introduce some testing of this new fixed handling e.g.by checking the number of remaining PIN attempts which was failing in the OS#6970. Said test could be introduced together with this patch so we can immediately see it now works?",
"revId": "b990172d2de51d737d0506c33c392e434040f3e8", "revId": "b990172d2de51d737d0506c33c392e434040f3e8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326" "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "8f4ae6a0_453a8102",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 1000028
},
"writtenOn": "2026-03-10T17:04:22Z",
"side": 1,
"message": "We could integrate a testcase into the already existing APDU tests by trying if apdu 0020000A00 returns 63c3 properly. That would cover the changes. Without this patch we would get 6f00.",
"parentUuid": "1c965320_ca854445",
"revId": "b990172d2de51d737d0506c33c392e434040f3e8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
} }
] ]
} }