mirror of
https://gitea.osmocom.org/sim-card/pysim.git
synced 2026-03-19 20:08:36 +03:00
Update patch set 1
Patch Set 1:
(10 comments)
Patch-set: 1
CC: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000004
committed by
Gerrit Code Review
Gerrit Code Review
parent
71a53d96ca
commit
f588e09d7e
228
d9ef1d314b3bebcc125ea394493a9a725c405a46
Normal file
228
d9ef1d314b3bebcc125ea394493a9a725c405a46
Normal file
@@ -0,0 +1,228 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6f384f16_3412eeb9",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 5,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "an eUICC must not be a card, in fact most often it is not. I would just write \"of SIM/USIM/UICC/eUICC.\" or something like that.",
|
||||
"range": {
|
||||
"startLine": 5,
|
||||
"startChar": 95,
|
||||
"endLine": 5,
|
||||
"endChar": 100
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "a1dca5bb_cf9dcc7e",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "\"... SMPP server (such as a production SMSC of a live cellular network) as well.\"\n\nI think it makes sense to clarify that one can use this in a production setup if one is an operator and has SMPP access to ones own SMSC.",
|
||||
"range": {
|
||||
"startLine": 6,
|
||||
"startChar": 111,
|
||||
"endLine": 7,
|
||||
"endChar": 6
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "a433b6d8_ae166f51",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 17,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "it\u0027s not \"a set\" but \"sets of keys\".. Somehow the paragraph doesn\u0027t really make it clear that the SCP80 keys must be used. You just say that the SCP80 protocol is used, and not that therem ight be different sets of keys for different SCPs and one of the SCP80 keysets must be used.",
|
||||
"range": {
|
||||
"startLine": 17,
|
||||
"startChar": 73,
|
||||
"endLine": 17,
|
||||
"endChar": 77
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "5a0511ef_2bd90920",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 17,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "we have many more instances of \"card\" in the document, it seems. Maybe add an initial paragraph at the top that whenever \"SIM\" is used, any of UICC/USIM/ISIM/eUICC/eSIM is actually meant? Or one could also do the same with the word \"card\": Define the word \"card\" in the context of this document as \"any SIM/USIM/ISIM/UICC/eUICC/eSIM whether or not it is in a physical card or solder form-factor\"?",
|
||||
"range": {
|
||||
"startLine": 17,
|
||||
"startChar": 17,
|
||||
"endLine": 17,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c23d3254_fea15b03",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 26,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "oh, are you sure? That means you cannot deploy new SCP80 (or other) keys via SCP80? I would have assumed that using RAM one could also issue PUT KEY and then the KIK would be used? Do you have a spec reference for your statement that it\u0027s not used?",
|
||||
"range": {
|
||||
"startLine": 26,
|
||||
"startChar": 62,
|
||||
"endLine": 26,
|
||||
"endChar": 104
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "29e48c59_b5678c82",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 28,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "the keyset doesn\u0027t have to be in the ISD. I think any security domain (whether issuer or supplementary) could in theory specify its own material? Might be best to just say \"security domain\" without being too specific.",
|
||||
"range": {
|
||||
"startLine": 28,
|
||||
"startChar": 19,
|
||||
"endLine": 28,
|
||||
"endChar": 67
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d24b1c40_3c72e02a",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 84,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "might be worth using formatting instructions to use monospaced font for all APDUs or other hex-strings",
|
||||
"range": {
|
||||
"startLine": 84,
|
||||
"startChar": 16,
|
||||
"endLine": 84,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "24338766_a56d9080",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "might be worth stating that he SIM RFM application is \"on the card\"",
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "72d2a4ae_e9bf2c30",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 119,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "it might be worth mentioning at some earlier point that the MSL of the card may be different for different card types/profiles, and that cards beyond lab/experimentation use should ideally have a MSL that makes the use of the counter mandatory. It\u0027s just the sysmoISIM-SJS1/SJA2/SJA5 that do not have a MSL requiring a counter as that makes it easier for lab/research type use.",
|
||||
"range": {
|
||||
"startLine": 115,
|
||||
"startChar": 1,
|
||||
"endLine": 119,
|
||||
"endChar": 93
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7d9b144f_664ade33",
|
||||
"filename": "docs/smpp-ota-tool.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 162,
|
||||
"author": {
|
||||
"id": 1000004
|
||||
},
|
||||
"writtenOn": "2026-02-27T13:04:29Z",
|
||||
"side": 1,
|
||||
"message": "\"... it will not wrap on overflow ...",
|
||||
"range": {
|
||||
"startLine": 162,
|
||||
"startChar": 57,
|
||||
"endLine": 162,
|
||||
"endChar": 64
|
||||
},
|
||||
"revId": "d9ef1d314b3bebcc125ea394493a9a725c405a46",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user