Compare commits

...

8 Commits

Author SHA1 Message Date
Gerrit User 1000004
d2e3219e05 Update patch set 4
Patch Set 4: Code-Review+1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 51a4410ddedb3224b6442e7027ff49a92fa303b1
2026-03-10 12:26:21 +00:00
Gerrit User 1000004
1f17ee5d28 Update patch set 4
Patch Set 4:

(1 comment)

Patch-set: 4
CC: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
2026-03-10 12:24:05 +00:00
Gerrit User 1000002
515ac4991e Update patch set 4
Patch Set 4: Verified-1

2 failed:
* [pylint] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=pylint,a1=default,a3=default,a4=default,label=osmocom-gerrit/2894/consoleFull
* [test] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=test,a1=default,a3=default,a4=default,label=simtester/2894/consoleFull

3 passed:
* [distcheck] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=distcheck,a1=default,a3=default,a4=default,label=osmocom-gerrit/2894/consoleFull
* [docs] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=docs,a1=default,a3=default,a4=default,label=osmocom-gerrit/2894/consoleFull
* [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/27327/consoleFull

Build Failed

Find the Retrigger button here:
https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2901/

Patch-set: 4
Tag: jenkins
Reviewer: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
Label: Verified=-1, 6a6a7d94ebd56ddeb70b0d21dd91fb13d9f1f728
2026-03-10 12:01:08 +00:00
Gerrit User 1000002
936a4dc783 Update patch set 4
Patch Set 4:

Build Started
https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2901/consoleFull

Patch-set: 4
Tag: jenkins
2026-03-10 11:40:02 +00:00
Gerrit User 1000028
12b40973e0 Create patch set 4
Uploaded patch set 4: Patch Set 3 was rebased.

Outdated Votes:
* Verified-1 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE")


Patch-set: 4
Subject: pySim/transport: fix GET RESPONSE behaviour
Commit: b990172d2d
Tag: autogenerated:gerrit:newPatchSet
Groups: c01abe29d5
2026-03-10 11:39:21 +00:00
Gerrit User 1000002
c2f8251f21 Update patch set 3
Patch Set 3: Verified-1

1 failed:
* [test] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=test,a1=default,a3=default,a4=default,label=simtester/2891/consoleFull

4 passed:
* [distcheck] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=distcheck,a1=default,a3=default,a4=default,label=osmocom-gerrit/2891/consoleFull
* [docs] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=docs,a1=default,a3=default,a4=default,label=osmocom-gerrit/2891/consoleFull
* [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/27324/consoleFull
* [pylint] https://jenkins.osmocom.org/jenkins/job/gerrit-pysim-build/JOB_TYPE=pylint,a1=default,a3=default,a4=default,label=osmocom-gerrit/2891/consoleFull

Build Failed

Find the Retrigger button here:
https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2898/

Patch-set: 3
Tag: jenkins
Reviewer: Gerrit User 1000002 <1000002@035e6965-6537-41bd-912c-053f3cf69326>
Label: Verified=-1, ea809ef0189f72b9d1d87475ea419db5ee65c6c6
2026-03-10 11:10:17 +00:00
Gerrit User 1000002
c7c397ee0e Update patch set 3
Patch Set 3:

Build Started
https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2898/consoleFull

Patch-set: 3
Tag: jenkins
2026-03-10 11:04:12 +00:00
Gerrit User 1000028
12cde75be6 Create patch set 3
Uploaded patch set 3.

Outdated Votes:
* Verified-1 (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE")


Patch-set: 3
Subject: pySim/transport: fix GET RESPONSE behaviour
Commit: 91c0886725
Tag: autogenerated:gerrit:newPatchSet
Groups: 91c0886725
2026-03-10 11:03:47 +00:00

View File

@@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "a594c7a9_a81dc36c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2026-03-10T12:24:05Z",
"side": 1,
"message": "I would argue actual bugfixes have higher priority and should hence be at the start of a patch series, and not at the end where they\u0027re blocked by more cosmetic changes in front of them",
"revId": "b990172d2de51d737d0506c33c392e434040f3e8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1c965320_ca854445",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2026-03-10T12:26:21Z",
"side": 1,
"message": "it would be good to introduce some testing of this new fixed handling e.g.by checking the number of remaining PIN attempts which was failing in the OS#6970. Said test could be introduced together with this patch so we can immediately see it now works?",
"revId": "b990172d2de51d737d0506c33c392e434040f3e8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}